Created attachment 146403 [details] [review] Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct
Created attachment 146404 [details] [review] Bug 32911: atomicupdate file
Created attachment 146405 [details] [review] Bug 32911: atomicupdate file
Created attachment 147417 [details] [review] Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 147418 [details] [review] Bug 32911: atomicupdate file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 147419 [details] [review] Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #6) > The new preference appeared under Notifications, but is better > suited for the Features section on the ILL tab in system > preferences. Thank you Katrin, I wasn't sure where this should be placed.
Kyle, can we move this back to "Signed-off"?
Yes [U+1F642]
Applying: Bug 32911: (follow-up) Move pref from Notifications to Features section error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/interlibrary_loans.pref).
I'll try to fix.
Created attachment 150672 [details] [review] Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150673 [details] [review] Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150674 [details] [review] Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 150750 [details] [review] Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150751 [details] [review] Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 150752 [details] [review] Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Discussed with Katrin, I have permission to QA some of the ILL bugs in the queue even though they're written by our team. There are few people in a position to properly review and QA ILL so she's trusting me to be unbiased. As such, this one is a pass, code works, it's a nice cleanup and the QA scripts are all happy too. Passing QA
Created attachment 150753 [details] [review] Bug 32911: (follow-up) Remove a couple of cases from tests This patch simply removes the partner_code defaults from some tests where it is no longer required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I find it really odd that Illrequest::Config.pm has partner_code as a 'setter' as well as getter.. it's never actually used in that way, but it is tested for. I reckon we can drop that functionality at a later date.
Doh.. I missed something (that Pedro asking a question just highlighted to me) We also need to remove it from the installer configs.. i.e debian/templates and /etc
Created attachment 150768 [details] [review] Bug 32911: (follow-up) Remove partner_code from debian and /etc koha-conf.xml files
Created attachment 150769 [details] [review] Bug 32911: (follow-up) Only move config value from koha-conf.xml if it exists
Created attachment 151011 [details] [review] Bug 32911: Remove ILL partner_code config from koha-conf.xml and turn it into a system preference Preparation: 1) apply patch 2) run reset_all 3) enable ILLModule sys preference 4) install a backend (e.g. FreeForm) 5) go into system preferences and confirm that ILLPartnerCode exists and is the default inter-library loan (IL) Test plan: 1) create an ILL request 2) ensure the patron of category 'IL' has a primary e-mail configured 3) click on "place request with partners" 4) verify that the patron(s) of said category are on the partners list Upgrade test: 1) Remove the system preference from the database, run query: delete from systempreferences where variable="ILLPartnerCode"; 2) Check or edit the value or partner_code in koha-conf.xml and run atomicupdate: installer/data/mysql/updatedatabase.pl 3) Confirm the value in koha-conf.xml has been successfully migrated into the system preference, run query: select * from systempreferences where variable="ILLPartnerCode"; Optional tests: - Set a patron category in the sys pref and then delete said patron category (needs to not have patrons in it) - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to the empty option - Check the about page -> System information and confirm the warning message is correct - Set the sys pref to a category that has no patrons of its type (ktd examples: Board, or Library) - Check the about page -> System information and confirm the warning message is correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151012 [details] [review] Bug 32911: Database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151013 [details] [review] Bug 32911: (follow-up) Move pref from Notifications to Features section The new preference appeared under Notifications, but is better suited for the Features section on the ILL tab in system preferences. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151014 [details] [review] Bug 32911: (follow-up) Remove a couple of cases from tests This patch simply removes the partner_code defaults from some tests where it is no longer required. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151015 [details] [review] Bug 32911: (follow-up) Remove partner_code from debian and /etc koha-conf.xml files Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151016 [details] [review] Bug 32911: (follow-up) Only move config value from koha-conf.xml if it exists Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Created attachment 155195 [details] [review] Bug 32911: (QA follow-up) Adjust tests This patch adjusts tests so they acknowledge the new syspref and the fact `partner_code` will be skipped if found on the config file. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Enhancement not pushed to 23.05.x
Looks like there are many wrong things here, please have a look at bug 34842.
(In reply to Jonathan Druart from comment #33) > Looks like there are many wrong things here, please have a look at bug 34842. s/many/a couple of/ ;)