Attachment 155204 Details for Bug 34502 – Bug 34502: Remove useless SEARCH_RESULT.localimage

[patch] Bug 34502: Remove useless SEARCH_RESULT.localimage

Bug-34502-Remove-useless-SEARCHRESULTlocalimage.patch (text/plain), 2.22 KB, created by David Nind on 2023-09-04 20:51:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-09-04 20:51:27 UTC

Size: 2.22 KB

patch

obsolete

>From 756a56769bbfafddff2061301431c5e864b8a7b6 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 9 Aug 2023 01:06:05 +0000
>Subject: [PATCH] Bug 34502: Remove useless SEARCH_RESULT.localimage
>
>This patch removes a useless Template Toolkit tag.
>
>To test:
>0. Apply the patch
>1. Go to
>http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LocalCoverImages
>2. Change to "Show"
>3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29
>4. Upload an image
>5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test
>6. Note that the local cover image appears even without the TT tag
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 78cec6a337..231eec76d3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -464,7 +464,7 @@
>                                             [% IF ( CoverImagePlugins || AmazonCoverImages  || LocalCoverImages || IntranetCoce || ( SyndeticsCovers ) || (Koha.Preference('CustomCoverImages') && Koha.Preference('CustomCoverImagesURL')) ) %]
>     <td class="bookcoverimg">
>         <div id="cover-slides-[% SEARCH_RESULT.biblionumber | html %]" class="cover-slides" data-biblionumber="[% SEARCH_RESULT.biblionumber | html %]" data-isbn="[% To.json(SEARCH_RESULT.normalized_isbn) | $raw %]" data-processedbiblio="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber | $raw %]">
>-            [% IF ( LocalCoverImages ) %][% SEARCH_RESULT.localimage | html %]
>+            [% IF ( LocalCoverImages ) %]
>                 <div id="local-coverimg-[% SEARCH_RESULT.biblionumber | html %]" class="cover-image local-coverimg">
>                     <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]">
>                         <img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&amp;biblionumber=[% SEARCH_RESULT.biblionumber | uri %]" alt="Local cover image" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34502: 154325 | 155204 | 155470