In ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt the following line is useless: [% SEARCH_RESULT.localimage | html %] This hash key doesn't exist so it just renders nothing.
Created attachment 154325 [details] [review] Bug 34502: Remove useless SEARCH_RESULT.localimage This patch removes a useless Template Toolkit tag. To test: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LocalCoverImages 2. Change to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Upload an image 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Note that the local cover image appears even without the TT tag
Created attachment 155204 [details] [review] Bug 34502: Remove useless SEARCH_RESULT.localimage This patch removes a useless Template Toolkit tag. To test: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LocalCoverImages 2. Change to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Upload an image 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Note that the local cover image appears even without the TT tag Signed-off-by: David Nind <david@davidnind.com>
It comes from Bug 25846 And looks like a typo in trying to use localimages Because found no relevant "localimage" in the diffs or all the commits of Koha (thanks `git log -p` and ripgrep to grep that) But at the time of 25846 and now, localimage is only in opac/opac-detail.pl catalogue/detail.pl Anyway, it's not working since it's introduction in 21.05 so it being a typo doesn't warrant digging more into. Stuff was always dead and nobody complained ^^ Code looks good :) Just need to test.
Created attachment 155470 [details] [review] Bug 34502: Remove useless SEARCH_RESULT.localimage This patch removes a useless Template Toolkit tag. To test: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=LocalCoverImages 2. Change to "Show" 3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29 4. Upload an image 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Note that the local cover image appears even without the TT tag Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Nice work everyone! Pushed to oldstable for 22.11.x