Bugzilla – Attachment 156246 Details for
Bug 34917
Fix suggestions.tt table default sort column
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34917: Fix default sort column of table in suggestion.tt
Bug-34917-Fix-default-sort-column-of-table-in-sugg.patch (text/plain), 1.50 KB, created by
David Nind
on 2023-09-26 20:30:04 UTC
(
hide
)
Description:
Bug 34917: Fix default sort column of table in suggestion.tt
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-09-26 20:30:04 UTC
Size:
1.50 KB
patch
obsolete
>From ef00f164bea989a7f79c48449933dea897d2d9e5 Mon Sep 17 00:00:00 2001 >From: Jacob O'Mara <jacobomara901@gmail.com> >Date: Tue, 26 Sep 2023 15:19:45 +0100 >Subject: [PATCH] Bug 34917: Fix default sort column of table in suggestion.tt > >Test plan: >1. Navigate to Acquisitions and load the suggestions management page >2. Ensure that there are some suggestions in the table >3. Observe that the default sort is on the "Suggester Category" column >4. Apply Patch >5. Observe that the default sort is now on the "Suggested on" column > instead > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: David Nind <david@davidnind.com> >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 1ff0fb6c83..937fe63e20 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1347,7 +1347,7 @@ > [% FOREACH suggestion IN suggestions %] > [% IF suggestion.suggestions.size %] > KohaTable("table_[% loop.count| html %]", { >- "sorting": [[ 3, "asc" ]], >+ "sorting": [[ 4, "asc" ]], > "autoWidth": false, > }, table_settings ); > [% END %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34917
:
156233
|
156245
|
156246
|
156378