Bug 34917 - Fix suggestions.tt table default sort column
Summary: Fix suggestions.tt table default sort column
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jacob O'Mara
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32603
Blocks:
  Show dependency treegraph
 
Reported: 2023-09-26 14:04 UTC by Jacob O'Mara
Modified: 2023-10-17 13:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 34917: Fix default sort column of table in suggestion.tt (1.40 KB, patch)
2023-09-26 14:28 UTC, Jacob O'Mara
Details | Diff | Splinter Review
Bug 34917: Fix default sort column of table in suggestion.tt (1.46 KB, patch)
2023-09-26 20:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34917: Fix default sort column of table in suggestion.tt (1.50 KB, patch)
2023-09-26 20:30 UTC, David Nind
Details | Diff | Splinter Review
Bug 34917: Fix default sort column of table in suggestion.tt (1.56 KB, patch)
2023-09-29 11:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacob O'Mara 2023-09-26 14:04:30 UTC
Bug_32603 introduced a new column to the table in suggestion.tt. Due to the default sort being set to the 3rd column this moved the sort from "suggested on" to "Suggester category" on table load which is not ideal. This should be moved back to the "Suggested on" column.
Comment 1 Jacob O'Mara 2023-09-26 14:28:39 UTC
Created attachment 156233 [details] [review]
Bug 34917: Fix default sort column of table in suggestion.tt

Test plan:
1. Navigate to Acquisitions and load the suggestions management page
2. Ensure that there are some suggestions in the table
3. Observe that the default sort is on the "Suggester Category" column
4. Apply Patch
5. Observe that the default sort is now on the "Suggested on" column
   instead
Comment 2 Lucas Gass 2023-09-26 20:22:18 UTC
Created attachment 156245 [details] [review]
Bug 34917: Fix default sort column of table in suggestion.tt

Test plan:
1. Navigate to Acquisitions and load the suggestions management page
2. Ensure that there are some suggestions in the table
3. Observe that the default sort is on the "Suggester Category" column
4. Apply Patch
5. Observe that the default sort is now on the "Suggested on" column
   instead

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 David Nind 2023-09-26 20:30:04 UTC
Created attachment 156246 [details] [review]
Bug 34917: Fix default sort column of table in suggestion.tt

Test plan:
1. Navigate to Acquisitions and load the suggestions management page
2. Ensure that there are some suggestions in the table
3. Observe that the default sort is on the "Suggester Category" column
4. Apply Patch
5. Observe that the default sort is now on the "Suggested on" column
   instead

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2023-09-29 11:19:34 UTC
Created attachment 156378 [details] [review]
Bug 34917: Fix default sort column of table in suggestion.tt

Test plan:
1. Navigate to Acquisitions and load the suggestions management page
2. Ensure that there are some suggestions in the table
3. Observe that the default sort is on the "Suggester Category" column
4. Apply Patch
5. Observe that the default sort is now on the "Suggested on" column
   instead

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi 2023-10-03 13:20:27 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-10-05 19:28:55 UTC
Pushed to 23.05.x for 23.05.05
Comment 7 Jacob O'Mara 2023-10-17 13:45:41 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x