Attachment 156439 Details for Bug 34942 – Bug 34942: Fix typo - 'brower' to 'browser'

[patch] Bug 34942: Fix typo - 'brower' to 'browser'

Bug-34942-Fix-typo---brower-to-browser.patch (text/plain), 2.01 KB, created by David Nind on 2023-09-30 09:43:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-09-30 09:43:58 UTC

Size: 2.01 KB

patch

obsolete

>From 29ee3be2a3f800d6e4379395e7011f402cf1e8b1 Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Sat, 30 Sep 2023 09:03:06 +0000
>Subject: [PATCH] Bug 34942: Fix typo - 'brower' to 'browser'
>
>This fixes a typo in a message used in the advanced cataloguing
>editor when macros are converted from being stored in the browser to
>being stored in the database (bug 17268 - Advanced cataloging editor
>- rancor - macros are lost when browser storage cleared).
>
>Test plan:
>1. Search for 'brower' in the codebase - there should be one occurance:
>   grep -rn --exclude=*.po brower *
>2. Apply the patch.
>3. Run the search in step 1 again, there should now be no occurances.
>4. Review the diff for the patch a nd make sure that the change makes
>   sense.
>5. Sign off! 8-)
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>index 4e26c58aac..6f5d607166 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
>@@ -870,7 +870,7 @@ require( [ 'koha-backend', 'search', 'macros', 'marc-editor', 'marc-record', 'pr
>         if( Object.keys(Preferences.user.macros).length ){
>             $convert = $( '<button class="btn btn-default" id="convert-macros" title="'+_("Convert browser storage macros")+'><i class="fa fa-adjust" aria-hidden="true"></i> Convert old macros</button>' );
>             $convert.click( function(){
>-                if( !confirm( _("This will retrieve macros stored in the brower, save them in the database, and delete them from the browser. Proceed?") ) ){
>+                if( !confirm( _("This will retrieve macros stored in the browser, save them in the database, and delete them from the browser. Proceed?") ) ){
>                     return;
>                 }
>                 convertOldMacros();
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34942: 156439 | 156463 | 156486