$ grep -rn --exclude=*.po brower * koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc:873: if( !confirm( _("This will retrieve macros stored in the brower, save them in the database, and delete them from the browser. Proceed?") ) ){ koha-tmpl/intranet-tmpl/prog/nb-NO/includes/cateditor-ui.inc:873: if( !confirm( _("This will retrieve macros stored in the brower, save them in the database, and delete them from the browser. Proceed?") ) ){
Created attachment 156439 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com>
I'm not sure of the best way to update the nb-NO files - is this handled by the translation process?
(In reply to David Nind from comment #2) > I'm not sure of the best way to update the nb-NO files - is this handled by > the translation process? Yes it is. Thanks for the fix!
Created attachment 156463 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 156486 [details] [review] Bug 34942: Fix typo - 'brower' to 'browser' This fixes a typo in a message used in the advanced cataloguing editor when macros are converted from being stored in the browser to being stored in the database (bug 17268 - Advanced cataloging editor - rancor - macros are lost when browser storage cleared). Test plan: 1. Search for 'brower' in the codebase - there should be one occurance: grep -rn --exclude=*.po brower * 2. Apply the patch. 3. Run the search in step 1 again, there should now be no occurances. 4. Review the diff for the patch a nd make sure that the change makes sense. 5. Sign off! 8-) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.05
Nice work everyone! Pushed to oldstable for 22.11.x