Attachment 156465 Details for Bug 34389 – Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

[patch] Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header

Bug-34389-Fix-inconsistencies-in-debit-types-title.patch (text/plain), 2.62 KB, created by David Nind on 2023-10-02 23:39:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-10-02 23:39:53 UTC

Size: 2.62 KB

patch

obsolete

>From 8a78ea9f66d8e6392ae77da0985d5ab669657daf Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 2 Oct 2023 15:43:29 +0000
>Subject: [PATCH] Bug 34389: Fix inconsistencies in debit types titles,
> breadcrumbs, and header
>
>This patch fixes a couple of inconsistencies in the debit types
>administration page, making sure the page title, breadcrumb
>navigation, and page headers are consistent with each other.
>
>To test, apply the patch and go to Administration -> Debit types. Test
>each variation of the page:
>
>- Main page
>- New debit type
>- Modify debit type
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/admin/debit_types.tt    | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>index c28a95cc8e..66766287c6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/debit_types.tt
>@@ -9,7 +9,7 @@
> <title>[% FILTER collapse %]
>     [% IF op =='add_form' %]
>        [% IF debit_type.code %]
>-           [% t("Modify debit type") | html %]
>+           [% tx("Modify debit type '{debit_type}'", { debit_type = debit_type.code }) | html %]
>        [% ELSE %]
>            [% t("New debit type") | html %]
>        [% END %] &rsaquo;
>@@ -38,7 +38,7 @@
>             [% END %]
>             [% WRAPPER breadcrumb_item bc_active= 1 %]
>                 [% IF debit_type.code %]
>-                    <span>Modify debit type</span>
>+                    [% tx("Modify debit type '{debit_type}'", { debit_type = debit_type.code }) | html %]
>                 [% ELSE %]
>                     <span>New debit type</span>
>                 [% END %]
>@@ -76,7 +76,7 @@
> 
>                 [% IF op == 'add_form' %]
>                     [% IF debit_type %]
>-                        <h1>Modify a debit type</h1>
>+                        <h1>[% tx("Modify debit type '{debit_type}'", { debit_type = debit_type.code }) | html %]</h1>
>                     [% ELSE %]
>                         <h1>New debit type</h1>
>                     [% END %]
>@@ -159,7 +159,7 @@
>                         <a class="btn btn-default" id="newdebittype" href="/cgi-bin/koha/admin/debit_types.pl?op=add_form"><i class="fa fa-plus"></i> New debit type</a>
>                     </div>
> 
>-                    <h1>Account debit types</h1>
>+                    <h1>Debit types</h1>
>                     [% IF debit_types.count %]
>                         <div class="page-section">
>                             <table id="table_debit_types">
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34389: 156457 | 156465 | 156484