While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Debit types page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add debit type code to Modify X (e.g. Modify debit type 'MANUAL') Breadcrumb - Add debit type code to Modify X (e.g. Modify debit type 'MANUAL') Page header - Change 'Modify a debit type' to "Modify debit type 'Y'"
Created attachment 156457 [details] [review] Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type
Created attachment 156465 [details] [review] Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type Signed-off-by: David Nind <david@davidnind.com>
Created attachment 156484 [details] [review] Bug 34389: Fix inconsistencies in debit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the debit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Debit types. Test each variation of the page: - Main page - New debit type - Modify debit type Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Not pushed to 23.05.x