Bugzilla – Attachment 156771 Details for
Bug 34300
Add link to place a hold on ordered items in baskets
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34300: (QA follow-up) Add permission check and fix missing table cells
Bug-34300-QA-follow-up-Add-permission-check-and-fi.patch (text/plain), 4.05 KB, created by
Katrin Fischer
on 2023-10-09 21:47:13 UTC
(
hide
)
Description:
Bug 34300: (QA follow-up) Add permission check and fix missing table cells
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-09 21:47:13 UTC
Size:
4.05 KB
patch
obsolete
>From d94cd61f3574e7ca0a9783868cd4177a63a12683 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 9 Oct 2023 21:29:13 +0000 >Subject: [PATCH] Bug 34300: (QA follow-up) Add permission check and fix > missing table cells > >* Changes text from "Place a hold on order" to the more common "Place hold" >* Adds permission check on reserveforothers. >* We were missing table cells in the footer rows of the table. > >I would have liked to hide the column for someone missing permissions, >but I failed to get the datatable configuration right with the export >and column configuration settings. >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index fd208325cf..0349944425 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -482,7 +482,7 @@ > [% IF Koha.Preference('EDIFACT') && ediaccount %] > <th>Supplier report</th> > [% END %] >- <th>Place hold</th> >+ <th class="NoSort">Place hold</th> > [% IF ( active ) %] > [% UNLESS ( closedate ) %] > <th class="NoSort">Modify</th> >@@ -516,6 +516,7 @@ > [% IF Koha.Preference('EDIFACT') && ediaccount %] > <th> </th> > [% END %] >+ <th> </th> > [% IF ( active ) %] > [% UNLESS ( closedate ) %] > <th> </th> >@@ -547,6 +548,7 @@ > [% IF Koha.Preference('EDIFACT') && ediaccount %] > <th> </th> > [% END %] >+ <th> </th> > [% IF ( active ) %] > [% UNLESS ( closedate ) %] > <th> </th> >@@ -677,9 +679,11 @@ > <td>[% books_loo.suppliers_report | html %]</td> > [% END %] > <td> >- <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]"> >- Place a hold on the order >- </a> >+ [% IF ( CAN_user_reserveforothers_place_holds ) %] >+ <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% books_loo.biblionumber | uri %]"> >+ Place hold >+ </a> >+ [% END %] > </td> > [% IF ( active ) %] > [% UNLESS ( closedate ) %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34300
:
153579
|
153622
|
156367
|
156771
|
156983