Libraries would like the ability to easily place a hold on an ordered item from the basket. We envision this button being available next to orders, by the other action buttons i.e. next to Modify/transfer and Cancel. It would be in its own column "Place hold" and should be configurable to show or hide using the Table settings.
Created attachment 153579 [details] [review] Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College
Created attachment 153622 [details] [review] Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Worked as expected, I know lots of people will be excited to see this. Lisette
(In reply to Lisette Scheer from comment #3) > Worked as expected, I know lots of people will be excited to see this. > Lisette Thanks Lisette! That's great to hear :)
Created attachment 156367 [details] [review] Bug 34300: Add holds column to order table Adds the ability to easily place a hold on an ordered item from a basket To test: 1) Apply patch 2) Go to acquisitions 3) Go to an existing basket, or create a new one 4) Add an order to the basket 4) Notice there is a "Place hold" column in the Orders table 5) Click the link for an item which allows you to place a hold easily on the biblio 6) On the columns settings, toggle the "Place hold" column to hide it, and make sure it gets hidden Sponsored-by: Pymble Ladies’ College Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passing QA with a few minor comments: Place a hold on the order is a bit weird wording imho. Could be improved? No blocker. I wonder if Place hold should be hidden by default. If you want it, you will enable it? No blocker. The list of column settings (in Configure) is not ordered. This is outside scope here. But we might wanna think about that..
Pushed to master for 23.11. Nice work everyone, thanks!
This needs a check for permission 'CAN_user_reserveforothers_place_holds' right ?
Created attachment 156771 [details] [review] Bug 34300: (QA follow-up) Add permission check and fix missing table cells * Changes text from "Place a hold on order" to the more common "Place hold" * Adds permission check on reserveforothers. * We were missing table cells in the footer rows of the table. I would have liked to hide the column for someone missing permissions, but I failed to get the datatable configuration right with the export and column configuration settings.
Can I get a review on the follow-up?
*** Bug 10498 has been marked as a duplicate of this bug. ***
Created attachment 156983 [details] [review] Bug 34300: (QA follow-up) Add permission check and fix missing table cells * Changes text from "Place a hold on order" to the more common "Place hold" * Adds permission check on reserveforothers. * We were missing table cells in the footer rows of the table. I would have liked to hide the column for someone missing permissions, but I failed to get the datatable configuration right with the export and column configuration settings. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Thx Nick!
Follow-up pushed to master. Thanks!