Bugzilla – Attachment 156880 Details for
Bug 35037
Revise the appearance of the last patron button
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35037: Revise the appearance of the last patron button
Bug-35037-Revise-the-appearance-of-the-last-patron.patch (text/plain), 4.59 KB, created by
David Nind
on 2023-10-11 21:42:40 UTC
(
hide
)
Description:
Bug 35037: Revise the appearance of the last patron button
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-10-11 21:42:40 UTC
Size:
4.59 KB
patch
obsolete
>From b5f3cf67603b87693d2d401a62642c1970493381 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 11 Oct 2023 17:41:45 +0000 >Subject: [PATCH] Bug 35037: Revise the appearance of the last patron button > >Following Bug 21246 I find the button to be too obtrusive. This patch >makes CSS changes to the style of the "Last patron" button shown in the >staff interface when the "showLastPatron" system preference is enabled. > >To test, apply the patch and rebuild the staff interface CSS. > >- Enable the showLastPatron system preference if necessary. >- Go to Circulation in the staff interface and check out to a patron. >- A "Last patron" button should appear on the right-hand end of the > breadcrumbs bar. >- Check that the link, dropdown button, and dropdown menu look good. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/css/src/_header.scss | 13 +++++++++++-- > .../intranet-tmpl/prog/css/src/staff-global.scss | 10 +++++++++- > .../prog/en/includes/last-borrower.inc | 6 +++--- > .../intranet-tmpl/prog/en/includes/shortcut.inc | 4 +++- > 4 files changed, 26 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss >index 946ce293d2..eec9046e44 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss >@@ -295,8 +295,17 @@ a.navbar-toggle { > } > > #lastborrowerlink { >- color: #FFFFFF; >- background-color: $background-color-primary; >+ font-size: 13px; >+ padding: 0 .7em; >+ >+ & + .dropdown-toggle { >+ margin-left: 0; >+ padding: .01em .7em; >+ >+ &:hover { >+ background-color: #FFF; >+ } >+ } > } > > @media (max-width: 768px) { >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 029ed50d4b..b12a703cd9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -941,6 +941,10 @@ details[open] { > justify-content: space-between; > } > >+#shortcut { >+ display: flex; >+} >+ > #breadcrumbs, #shortcut { > background-color: transparent; > clear: both; >@@ -3223,7 +3227,11 @@ label { > } > > > .btn:first-child:not( :last-child ):not( .dropdown-toggle ) { >- border-right: 1px solid darken( saturate( $btn-primary, 15 ), 15 ); >+ border-right: 1px solid #CCC; >+ >+ &.btn-primary { >+ border-right: 1px solid darken( saturate( $btn-primary, 15 ), 15 ); >+ } > } > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc >index 844bca2aaa..86b93f9813 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/last-borrower.inc >@@ -3,12 +3,12 @@ > </script> > <div id="lastborrower-window"> > <div class="btn-group"> >- <a class="btn btn-default navbar-btn lastborrower" id="lastborrowerlink" href="#" title=""><i class="fa fa-arrow-right"></i> Last patron</a> >- <button type="button" data-toggle="dropdown" class="btn btn-default navbar-btn dropdown-toggle" aria-haspopup="true" aria-expanded="false"> >+ <a class="btn btn-link navbar-btn lastborrower" id="lastborrowerlink" href="#" title=""><i class="fa fa-arrow-right"></i> Last patron</a> >+ <button type="button" data-toggle="dropdown" class="btn btn-link navbar-btn dropdown-toggle" aria-haspopup="true" aria-expanded="false"> > <span class="caret"></span> > <span class="sr-only">Toggle Dropdown</span> > </button> >- <ul id="lastBorrowerList" class="dropdown-menu"> >+ <ul id="lastBorrowerList" class="dropdown-menu dropdown-menu-right"> > <li role="separator" class="divider"></li> > <li><a id="lastborrower-remove" class="lastborrower" href="#">Clear list</a></li> > </ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/shortcut.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/shortcut.inc >index b602a2c21c..01a5924a69 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/shortcut.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/shortcut.inc >@@ -3,5 +3,7 @@ > [% INCLUDE 'last-borrower.inc' %] > [% END %] > >- <a class="toplinks" href="/cgi-bin/koha/help.pl" id="helper"><i class="fa-solid fa-circle-question"></i> <span>Help</span></a> >+ <div> >+ <a class="" href="/cgi-bin/koha/help.pl" id="helper"><i class="fa-solid fa-circle-question"></i> <span>Help</span></a> >+ </div> > </nav> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35037
:
156872
|
156880
|
156936
|
157085
|
157086
|
157130
|
157131