I think the last patron button looks too big following the changes made in Bug 21246. I would like to propose a less obtrusive version.
Created attachment 156872 [details] [review] Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good.
This looks pretty good! I think it could use a bit of whitespace between the arrow and the help link to avoid accidental clicks.
Created attachment 156880 [details] [review] Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com>
It looks great to me! I like that the name + card number are now aligned properly and aren't cut off. Maybe some more space between the dropdown list and the Help link, but a great improvement!
Can you add more space please? :)
Created attachment 156936 [details] [review] Bug 35037: (follow-up) Minor adjustments to margins and padding
Created attachment 157085 [details] [review] Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 157086 [details] [review] Bug 35037: (follow-up) Minor adjustments to margins and padding Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 157130 [details] [review] Bug 35037: Revise the appearance of the last patron button Following Bug 21246 I find the button to be too obtrusive. This patch makes CSS changes to the style of the "Last patron" button shown in the staff interface when the "showLastPatron" system preference is enabled. To test, apply the patch and rebuild the staff interface CSS. - Enable the showLastPatron system preference if necessary. - Go to Circulation in the staff interface and check out to a patron. - A "Last patron" button should appear on the right-hand end of the breadcrumbs bar. - Check that the link, dropdown button, and dropdown menu look good. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 157131 [details] [review] Bug 35037: (follow-up) Minor adjustments to margins and padding Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x