Bugzilla – Attachment 158012 Details for
Bug 35112
[22.11] Return claims table showing on all patron tabs and not behaving as normal
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[22.11] Bug 35112: Fix return claims table showing on other patron tabs
Bug-35112-Fix-return-claims-table-showing-on-other.patch (text/plain), 4.17 KB, created by
Katrin Fischer
on 2023-10-28 12:36:37 UTC
(
hide
)
Description:
[22.11] Bug 35112: Fix return claims table showing on other patron tabs
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-10-28 12:36:37 UTC
Size:
4.17 KB
patch
obsolete
>From 28e3300931af37c8930f43d6219715ad2479dad8 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleisha@catalyst.net.nz> >Date: Fri, 20 Oct 2023 01:02:30 +0000 >Subject: [PATCH] Bug 35112: Fix return claims table showing on other patron > tabs > >This patch fixes some unintentional changes introduced by Bug 25023. > >To test: > >1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims. >2. Check out an item >3. Submit a return claim for the checkout >4. Refresh the patron page >5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions. >6. Apply the patch and refresh the page >7. Confirm the return claims table only shows when viewing the Claims tab, as expected. > >Sponsored-by: Pymble Ladies' College >Signed-off-by: Kelly <kelly@bywatersolutions.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/en/includes/patron-return-claims.inc | 52 ++++++++++--------- > 1 file changed, 27 insertions(+), 25 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc >index c0b40e6806..ec2771ab94 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc >@@ -1,25 +1,27 @@ >-<p id="return-claims-controls"> >- [% IF ( patron.return_claims.resolved.count > 0 || patron.return_claims.unresolved.count > 0 ) %] >- <a id="show_all_claims" class="ctrl_link" href="#">Show all [% patron.return_claims.count | html %] claim(s)</a> >- <a id="show_unresolved_claims" class="ctrl_link disabled" href="#">Show [% patron.return_claims.unresolved.count | html %] unresolved claims</a> >- [% ELSE %] >- <a id="show_all_claims" class="ctrl_link" href="#"></a> >- <a id="show_unresolved_claims" class="ctrl_link disabled" href="#"></a> >- [% END %] >-</p> >-<table id="return-claims-table" class="table table-bordered table-striped"> >- <thead> >- <tr> >- <th class="return-claim-id">Claim ID</th> >- <th class="return-claim-id">Resolved?</th> >- <th class="return-claim-record-title anti-the">Title</th> >- <th class="return-claim-notes">Notes</th> >- <th class="return-claim-created-on">Created on</th> >- <th class="return-claim-created-on">Created on</th> >- <th class="return-claim-updated-on">Updated on</th> >- <th class="return-claim-updated-on">Updated on</th> >- <th class="return-claim-resolution">Resolution</th> >- <th class="return-claim-actions NoSort"> </th> >- </tr> >- </thead> >-</table> >+<div id="return-claims" role="tabpanel" class="tab-pane"> >+ <p id="return-claims-controls"> >+ [% IF ( patron.return_claims.resolved.count > 0 || patron.return_claims.unresolved.count > 0 ) %] >+ <a id="show_all_claims" class="ctrl_link" href="#">Show all [% patron.return_claims.count | html %] claim(s)</a> >+ <a id="show_unresolved_claims" class="ctrl_link disabled" href="#">Show [% patron.return_claims.unresolved.count | html %] unresolved claims</a> >+ [% ELSE %] >+ <a id="show_all_claims" class="ctrl_link" href="#"></a> >+ <a id="show_unresolved_claims" class="ctrl_link disabled" href="#"></a> >+ [% END %] >+ </p> >+ <table id="return-claims-table" class="table table-bordered table-striped"> >+ <thead> >+ <tr> >+ <th class="return-claim-id">Claim ID</th> >+ <th class="return-claim-id">Resolved?</th> >+ <th class="return-claim-record-title anti-the">Title</th> >+ <th class="return-claim-notes">Notes</th> >+ <th class="return-claim-created-on">Created on</th> >+ <th class="return-claim-created-on">Created on</th> >+ <th class="return-claim-updated-on">Updated on</th> >+ <th class="return-claim-updated-on">Updated on</th> >+ <th class="return-claim-resolution">Resolution</th> >+ <th class="return-claim-actions NoSort"> </th> >+ </tr> >+ </thead> >+ </table> >+</div> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35112
:
157483
|
157528
| 158012 |
159854