Bug 35112 - [22.11] Return claims table showing on all patron tabs and not behaving as normal
Summary: [22.11] Return claims table showing on all patron tabs and not behaving as no...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Aleisha Amohia
QA Contact: Katrin Fischer
URL:
Keywords: rel_22_11_candidate
: 35252 (view as bug list)
Depends on: 25023
Blocks:
  Show dependency treegraph
 
Reported: 2023-10-20 00:57 UTC by Aleisha Amohia
Modified: 2024-02-14 15:21 UTC (History)
14 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.12


Attachments
Bug 35112: Fix return claims table showing on other patron tabs (4.07 KB, patch)
2023-10-20 01:06 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 35112: Fix return claims table showing on other patron tabs (4.12 KB, patch)
2023-10-20 14:37 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
[22.11] Bug 35112: Fix return claims table showing on other patron tabs (4.17 KB, patch)
2023-10-28 12:36 UTC, Katrin Fischer
Details | Diff | Splinter Review
Screenshot from Checkout tab in 23.05. (102.78 KB, image/png)
2023-12-14 18:11 UTC, Christopher Brannon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2023-10-20 00:57:27 UTC
This is due to the fix from Bug 25023
Comment 1 Aleisha Amohia 2023-10-20 01:06:01 UTC
Created attachment 157483 [details] [review]
Bug 35112: Fix return claims table showing on other patron tabs

This patch fixes some unintentional changes introduced by Bug 25023.

To test:

1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims.
2. Check out an item
3. Submit a return claim for the checkout
4. Refresh the patron page
5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions.
6. Apply the patch and refresh the page
7. Confirm the return claims table only shows when viewing the Claims tab, as expected.

Sponsored-by: Pymble Ladies' College
Comment 2 ByWater Sandboxes 2023-10-20 14:37:43 UTC
Created attachment 157528 [details] [review]
Bug 35112: Fix return claims table showing on other patron tabs

This patch fixes some unintentional changes introduced by Bug 25023.

To test:

1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims.
2. Check out an item
3. Submit a return claim for the checkout
4. Refresh the patron page
5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions.
6. Apply the patch and refresh the page
7. Confirm the return claims table only shows when viewing the Claims tab, as expected.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Comment 3 David Nind 2023-10-23 02:44:30 UTC
Hi Kelly.

It looks like you signed it off, but the status wasn't changed.

You may like to change the status on Bugzilla, so that you get the credit on the dashboard. 8-)

David
Comment 4 Aleisha Amohia 2023-10-23 21:34:58 UTC
Don't want this fix to get missed in 22.11 so have changed the status myself on your behalf Kelly - thanks for testing!
Comment 5 Fridolin Somers 2023-10-24 21:59:33 UTC
Looks like this is not in master, maybe since Bug 33528
Needs to be confirmed.
Comment 6 Aleisha Amohia 2023-10-24 22:01:16 UTC
(In reply to Fridolin Somers from comment #5)
> Looks like this is not in master, maybe since Bug 33528
> Needs to be confirmed.

No it is in 22.11, as per bug report :)
Comment 7 Marcel de Rooy 2023-10-27 07:13:19 UTC
I am on 22.11.x with 25023 applied. But I do not see what you mean?
Please clarify: 
"return claims table is showing strangely when viewing the other patron tabs".

I have both pages with/without patch. But I am overlooking it ?
What is strange exactly?
Comment 8 Katrin Fischer 2023-10-28 12:36:37 UTC
Created attachment 158012 [details] [review]
[22.11] Bug 35112: Fix return claims table showing on other patron tabs

This patch fixes some unintentional changes introduced by Bug 25023.

To test:

1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims.
2. Check out an item
3. Submit a return claim for the checkout
4. Refresh the patron page
5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions.
6. Apply the patch and refresh the page
7. Confirm the return claims table only shows when viewing the Claims tab, as expected.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Katrin Fischer 2023-10-28 12:36:53 UTC
I can see the strange behaviour on a clean 22.11.x branch. When switching between the tabs, the claims contents will also show when the holds or restrictions tab is active etc.

The patch fixes the faulty beaviour for me.

I cannot replicate the problem in a clean 23.05, so only 22.11 seems to be affected.
Comment 10 Marcel de Rooy 2023-10-30 12:36:44 UTC
(In reply to Marcel de Rooy from comment #7)
> I have both pages with/without patch. But I am overlooking it ?
> What is strange exactly?

I am seeing it now. Confirm that it is resolved under 22.11.
Should we change status or alert the RMaint ?
Comment 11 Katrin Fischer 2023-10-30 12:45:59 UTC
(In reply to Marcel de Rooy from comment #10)
> (In reply to Marcel de Rooy from comment #7)
> > I have both pages with/without patch. But I am overlooking it ?
> > What is strange exactly?
> 
> I am seeing it now. Confirm that it is resolved under 22.11.
> Should we change status or alert the RMaint ?

I was wondering the same thing, hoping the CC and the keyword together will do the trick now :)
Comment 12 Matt Blenkinsop 2023-10-31 09:42:03 UTC
I've made a note of this one - will be backporting next time I work through the queue :)
Comment 13 Phil Ringnalda 2023-11-03 16:19:38 UTC
*** Bug 35252 has been marked as a duplicate of this bug. ***
Comment 14 Aleisha Amohia 2023-11-12 22:09:13 UTC
Just bumping this, as I'm worried it's been missed for the latest 22.11 minor point.
Comment 15 Matt Blenkinsop 2023-11-13 14:29:39 UTC
Backported to 22.11.x
Comment 16 Christopher Brannon 2023-12-14 18:08:45 UTC
Our test server is on 23.05, and we are seeing this issue as well as on 22.11.  This is not isolated to 22.11.
Comment 17 Christopher Brannon 2023-12-14 18:11:49 UTC
Created attachment 159854 [details]
Screenshot from Checkout tab in 23.05.
Comment 18 Christopher Brannon 2023-12-14 18:15:42 UTC
Never mind.  My test went over to our 22.11 server.  23.05 looks good.  Sorry.