This is due to the fix from Bug 25023
Created attachment 157483 [details] [review] Bug 35112: Fix return claims table showing on other patron tabs This patch fixes some unintentional changes introduced by Bug 25023. To test: 1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims. 2. Check out an item 3. Submit a return claim for the checkout 4. Refresh the patron page 5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions. 6. Apply the patch and refresh the page 7. Confirm the return claims table only shows when viewing the Claims tab, as expected. Sponsored-by: Pymble Ladies' College
Created attachment 157528 [details] [review] Bug 35112: Fix return claims table showing on other patron tabs This patch fixes some unintentional changes introduced by Bug 25023. To test: 1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims. 2. Check out an item 3. Submit a return claim for the checkout 4. Refresh the patron page 5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions. 6. Apply the patch and refresh the page 7. Confirm the return claims table only shows when viewing the Claims tab, as expected. Sponsored-by: Pymble Ladies' College Signed-off-by: Kelly <kelly@bywatersolutions.com>
Hi Kelly. It looks like you signed it off, but the status wasn't changed. You may like to change the status on Bugzilla, so that you get the credit on the dashboard. 8-) David
Don't want this fix to get missed in 22.11 so have changed the status myself on your behalf Kelly - thanks for testing!
Looks like this is not in master, maybe since Bug 33528 Needs to be confirmed.
(In reply to Fridolin Somers from comment #5) > Looks like this is not in master, maybe since Bug 33528 > Needs to be confirmed. No it is in 22.11, as per bug report :)
I am on 22.11.x with 25023 applied. But I do not see what you mean? Please clarify: "return claims table is showing strangely when viewing the other patron tabs". I have both pages with/without patch. But I am overlooking it ? What is strange exactly?
Created attachment 158012 [details] [review] [22.11] Bug 35112: Fix return claims table showing on other patron tabs This patch fixes some unintentional changes introduced by Bug 25023. To test: 1. Set a LOST authorised value in the ClaimReturnedLostValue to enable return claims. 2. Check out an item 3. Submit a return claim for the checkout 4. Refresh the patron page 5. Notice the return claims table is showing strangely when viewing the other patron tabs i.e. Checkouts, Holds, Restrictions. 6. Apply the patch and refresh the page 7. Confirm the return claims table only shows when viewing the Claims tab, as expected. Sponsored-by: Pymble Ladies' College Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I can see the strange behaviour on a clean 22.11.x branch. When switching between the tabs, the claims contents will also show when the holds or restrictions tab is active etc. The patch fixes the faulty beaviour for me. I cannot replicate the problem in a clean 23.05, so only 22.11 seems to be affected.
(In reply to Marcel de Rooy from comment #7) > I have both pages with/without patch. But I am overlooking it ? > What is strange exactly? I am seeing it now. Confirm that it is resolved under 22.11. Should we change status or alert the RMaint ?
(In reply to Marcel de Rooy from comment #10) > (In reply to Marcel de Rooy from comment #7) > > I have both pages with/without patch. But I am overlooking it ? > > What is strange exactly? > > I am seeing it now. Confirm that it is resolved under 22.11. > Should we change status or alert the RMaint ? I was wondering the same thing, hoping the CC and the keyword together will do the trick now :)
I've made a note of this one - will be backporting next time I work through the queue :)
*** Bug 35252 has been marked as a duplicate of this bug. ***
Just bumping this, as I'm worried it's been missed for the latest 22.11 minor point.
Backported to 22.11.x
Our test server is on 23.05, and we are seeing this issue as well as on 22.11. This is not isolated to 22.11.
Created attachment 159854 [details] Screenshot from Checkout tab in 23.05.
Never mind. My test went over to our 22.11 server. 23.05 looks good. Sorry.