Bugzilla – Attachment 158617 Details for
Bug 34868
Add ability for SIP2 to distinguish missing item from other lost types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34868: (QA follow-up) Tidy sip_circulation_status
Bug-34868-QA-follow-up-Tidy-sipcirculationstatus.patch (text/plain), 2.46 KB, created by
Kyle M Hall (khall)
on 2023-11-07 19:30:49 UTC
(
hide
)
Description:
Bug 34868: (QA follow-up) Tidy sip_circulation_status
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2023-11-07 19:30:49 UTC
Size:
2.46 KB
patch
obsolete
>From a6bba0727be40e4873b499f00f49940f73af1b7a Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 7 Nov 2023 14:30:04 -0500 >Subject: [PATCH] Bug 34868: (QA follow-up) Tidy sip_circulation_status > >--- > C4/SIP/ILS/Item.pm | 33 +++++++++++++-------------------- > 1 file changed, 13 insertions(+), 20 deletions(-) > >diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm >index 5ed37bdea56..89bcd827081 100644 >--- a/C4/SIP/ILS/Item.pm >+++ b/C4/SIP/ILS/Item.pm >@@ -261,40 +261,33 @@ sub title_id { > } > > sub sip_circulation_status { >- my $self = shift; >+ my $self = shift; > my $server = shift; > > # Defines what lost status means "missing" for this SIP account > my $missing_status = $server->{account}->{lost_status_for_missing}; > > if ( $self->{_object}->get_transfer ) { >- return '10'; # in transit between libraries >- } >- elsif ( Koha::Checkouts::ReturnClaims->search({ itemnumber => $self->{_object}->id, resolution => undef })->count ) { >+ return '10'; # in transit between libraries >+ } elsif ( >+ Koha::Checkouts::ReturnClaims->search( { itemnumber => $self->{_object}->id, resolution => undef } )->count ) >+ { > return '11'; # claimed returned >- } >- elsif ( $missing_status && $self->{itemlost} && $missing_status eq $self->{itemlost} ) { >+ } elsif ( $missing_status && $self->{itemlost} && $missing_status eq $self->{itemlost} ) { > return '13'; # missing >- } >- elsif ( $self->{itemlost} ) { >+ } elsif ( $self->{itemlost} ) { > return '12'; # lost >- } >- elsif ( $self->{borrowernumber} ) { >+ } elsif ( $self->{borrowernumber} ) { > return '04'; # charged >- } >- elsif ( grep { $_->{itemnumber} == $self->{itemnumber} } @{ $self->{hold_attached} } ) { >+ } elsif ( grep { $_->{itemnumber} == $self->{itemnumber} } @{ $self->{hold_attached} } ) { > return '08'; # waiting on hold shelf >- } >- elsif ( $self->{location} and $self->{location} eq 'CART' ) { >+ } elsif ( $self->{location} and $self->{location} eq 'CART' ) { > return '09'; # waiting to be re-shelved >- } >- elsif ( $self->{damaged} ) { >+ } elsif ( $self->{damaged} ) { > return '01'; # damaged >- } >- elsif ( $self->{notforloan} < 0 ) { >+ } elsif ( $self->{notforloan} < 0 ) { > return '02'; # on order >- } >- else { >+ } else { > return '03'; # available > } # FIXME: 01-13 enumerated in spec. > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34868
:
156003
|
156027
|
158151
|
158614
|
158615
|
158616
|
158617
|
158768
|
158769
|
158770
|
158771