The SIP circulation status specifies that a 12 means an item is lost, and 13 means an item is missing. In Koha, missing items are simply a type of lost item so we never send a 13. This is an important distinction for some SIP based inventory tools. It would be good to be able to specify when lost status means "missing" at the SIP login level.
Created attachment 156003 [details] [review] Bug 34868: Add ability for SIP2 to distinguish missing item from other lost types The SIP circulation status specifies that a 12 means an item is lost, and 13 means an item is missing. In Koha, missing items are simply a type of lost item so we never send a 13. This is an important distinction for some SIP based inventory tools. It would be good to be able to specify when lost status means "missing" at the SIP login level. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t
Created attachment 156027 [details] [review] Bug 34868: Add ability for SIP2 to distinguish missing item from other lost types The SIP circulation status specifies that a 12 means an item is lost, and 13 means an item is missing. In Koha, missing items are simply a type of lost item so we never send a 13. This is an important distinction for some SIP based inventory tools. It would be good to be able to specify when lost status means "missing" at the SIP login level. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com>
I feel like the naming is a bit confusing: + missing_lost_status="4" Maybe: lost_status_for_missing? And it would be good to have some additional documentation in the form of a note/comment. I'd also like to see a test where we see what happens when the SIP option is not configured.
Created attachment 158151 [details] [review] Bug Bug 34868: (QA follow-up) Rename new option, add comments
I am sorry, but the follow-up appears untested: FAIL etc/SIPconfig.xml FAIL xml_valid 83: parser error : error parsing attribute name 83: parser error : attributes construct error 83: parser error : Couldn't find end of Start Tag login line 61 100: parser error : Opening and ending tag mismatch: accounts line 0 and login 101: parser error : Opening and ending tag mismatch: acsconfig line 0 and accounts 110: parser error : Extra content at the end of the document OK t/db_dependent/SIP/Transaction.t Processing additional checks * Commit title does not start with 'Bug XXXXX: ' - c91e7b374a A comment within an XML element is not allowed, maybe move to top or below? Also please have a look at the tests again: (In reply to Katrin Fischer from comment #3) > I'd also like to see a test where we see what happens when the SIP option is > not configured.
(In reply to Katrin Fischer from comment #5) > I am sorry, but the follow-up appears untested: > > FAIL etc/SIPconfig.xml > FAIL xml_valid > 83: parser error : error parsing attribute name > 83: parser error : attributes construct error > 83: parser error : Couldn't find end of Start Tag login line 61 > 100: parser error : Opening and ending tag mismatch: accounts line 0 and > login > 101: parser error : Opening and ending tag mismatch: acsconfig line 0 and > accounts > 110: parser error : Extra content at the end of the document > > OK t/db_dependent/SIP/Transaction.t Ack! I thought I'd fixed that! Maybe I didn't commit those changes.
Created attachment 158614 [details] [review] Bug 34868: Add ability for SIP2 to distinguish missing item from other lost types The SIP circulation status specifies that a 12 means an item is lost, and 13 means an item is missing. In Koha, missing items are simply a type of lost item so we never send a 13. This is an important distinction for some SIP based inventory tools. It would be good to be able to specify when lost status means "missing" at the SIP login level. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com>
Created attachment 158615 [details] [review] Bug 34868: (QA follow-up) Rename new option, add comments
Created attachment 158616 [details] [review] Bug 34868: (QA follow-up) Fix XML
Created attachment 158617 [details] [review] Bug 34868: (QA follow-up) Tidy sip_circulation_status
(In reply to Katrin Fischer from comment #5) > FAIL etc/SIPconfig.xml Fixed! > Processing additional checks > > * Commit title does not start with 'Bug XXXXX: ' - c91e7b374a Fixed! > (In reply to Katrin Fischer from comment #3) > > I'd also like to see a test where we see what happens when the SIP option is > > not configured. There is already a test for when the option is off. It's the two lines in the unit test file above the two lines I added!
Created attachment 158768 [details] [review] Bug 34868: Add ability for SIP2 to distinguish missing item from other lost types The SIP circulation status specifies that a 12 means an item is lost, and 13 means an item is missing. In Koha, missing items are simply a type of lost item so we never send a 13. This is an important distinction for some SIP based inventory tools. It would be good to be able to specify when lost status means "missing" at the SIP login level. Test Plan: 1) Apply this patch 2) prove t/db_dependent/SIP/Transaction.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158769 [details] [review] Bug 34868: (QA follow-up) Rename new option, add comments Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158770 [details] [review] Bug 34868: (QA follow-up) Fix XML Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 158771 [details] [review] Bug 34868: (QA follow-up) Tidy sip_circulation_status Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement not pushed to 23.05.x