Attachment 159022 Details for Bug 35174 – Bug 35174: Add a warning to the about page

[patch] Bug 35174: Add a warning to the about page

Bug-35174-Add-a-warning-to-the-about-page.patch (text/plain), 4.61 KB, created by Jonathan Druart on 2023-11-16 07:54:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-11-16 07:54:24 UTC

Size: 4.61 KB

patch

obsolete

>From e0bf9ed9ef60ca9cfd88c3b28a07c6583a562fec Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 16 Nov 2023 08:43:43 +0100
>Subject: [PATCH] Bug 35174: Add a warning to the about page
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> about.pl                                         |  5 +++++
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 10 +++++++++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
>diff --git a/about.pl b/about.pl
>index 0c0c0729e04..6c3175c2d8b 100755
>--- a/about.pl
>+++ b/about.pl
>@@ -48,6 +48,7 @@ use Koha::BackgroundJob;
> use Koha::BiblioFrameworks;
> use Koha::Biblios;
> use Koha::Email;
>+use Koha::I18N;
> use Koha::Patron::Categories;
> use Koha::Patrons;
> use Koha::Caches;
>@@ -291,6 +292,10 @@ if ( !defined C4::Context->config('use_zebra_facets') ) {
>     push @xml_config_warnings, { error => 'use_zebra_facets_entry_missing' };
> }
> 
>+unless ( Koha::I18N->_base_directory ) {
>+    $template->param( warnI18nMissing => 1 );
>+}
>+
> # ILL module checks
> if ( C4::Context->preference('ILLModule') ) {
>     my $warnILLConfiguration = 0;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index df6cca50a46..ab0422e79b8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -273,7 +273,7 @@
>                         [% SET warnMissingCompiledFiles = 1 %]
>                     [% END %]
>                     [% WRAPPER tab_panel tabname= "sysinfo" %]
>-                        [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing || warnMissingCompiledFiles || warnDbRowFormat %]
>+                        [% IF weasyprint_missing || warnPrefRequireChoosingExistingAuthority || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatronOPACPrivacy || warnPrefAnonymousPatronAnonSuggestions || warnPrefAnonymousPatronOPACPrivacy_PatronDoesNotExist || warnPrefAnonymousPatronAnonSuggestions_PatronDoesNotExist || warnPrefKohaAdminEmailAddress || warnPrefOpacHiddenItems || warnPrefPatronSelfRegistrationDefaultCategory || invalid_yesno.count || warnNoActiveCurrency || warnIsRootUser || xml_config_warnings.size || warnI18nMissing || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError || warnNoTemplateCaching || warnILLConfiguration || has_ai_issues || oauth2_missing_deps || bad_yaml_prefs || warnRelationships || log4perl_errors || config_bcrypt_settings_no_set || warnHiddenBiblionumbers.size || warnConnectBroker || elasticsearch_has_missing || warnMissingCompiledFiles || warnDbRowFormat %]
>                             [% IF ( warnDbRowFormat ) %]
>                                 <h2>Database row format incorrect</h2>
>                                 <p>Database tables with a row format other than 'DYNAMIC': [% warnDbRowFormat | html %]</p>
>@@ -519,6 +519,14 @@
>                                             </td>
>                                         </tr>
>                                     [% END %]
>+                                    [% IF warnI18nMissing %]
>+                                        <tr>
>+                                            <th scope="row"><strong>Warning</strong> </th>
>+                                            <td>
>+                                                The PO directory has not been found. See <a href="https://wiki.koha-community.org/wiki/Translation_files">the dedicated wiki page</a> for more information.
>+                                            </td>
>+                                        </tr>
>+                                    [% END %]
>                                     [% IF warnILLConfiguration %]
>                                         [% IF no_ill_backends %]
>                                             <tr>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35174: 159021 | 159022 | 159023 | 159024 | 159025 | 159038