Bug 35174 - Remove .po files from the codebase
Summary: Remove .po files from the codebase
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 27236 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-10-27 11:25 UTC by Jonathan Druart
Modified: 2023-11-22 14:39 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.06,22.11.12,22.05.17,21.11.26
Circulation function:


Attachments
Bug 35174: Do not explode if po dir does not exist (841 bytes, patch)
2023-11-16 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35174: Add a warning to the about page (4.61 KB, patch)
2023-11-16 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35174: Add misc/translator/po to .gitignore (781 bytes, patch)
2023-11-16 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35174: Don't run gulp po commands if po dir is missing (1.12 KB, patch)
2023-11-16 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35174: Don't run gulp po commands if po dir is missing (1.12 KB, patch)
2023-11-16 08:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35174: update control files for koha-l10n dependency package (1.39 KB, patch)
2023-11-16 10:14 UTC, Mason James
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-10-27 11:25:39 UTC
We should actually remove the .po files from the git history (Git_Splitting_and_Shrinking), but a first step could be to stop including them.

With the migration to Weblate we now have a new repository koha-l10n (https://gitlab.com/koha-community/koha-l10n) that contains the .po files (update regularly by Weblate).

Devs will simply need to git clone koha-l10n in misc/translate/po.

For prod we could have additional debian package(s), either koha-l10n with all the .po files or one per language (koha-l10n-fr).

Or, to start, we just embed all of them when building the package.
Comment 1 David Cook 2023-10-29 22:39:06 UTC
*** Bug 27236 has been marked as a duplicate of this bug. ***
Comment 2 Jonathan Druart 2023-11-16 07:54:21 UTC
Created attachment 159021 [details] [review]
Bug 35174: Do not explode if po dir does not exist

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2023-11-16 07:54:24 UTC
Created attachment 159022 [details] [review]
Bug 35174: Add a warning to the about page

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2023-11-16 07:54:27 UTC
Created attachment 159023 [details] [review]
Bug 35174: Add misc/translator/po to .gitignore

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Jonathan Druart 2023-11-16 07:54:30 UTC
Created attachment 159024 [details] [review]
Bug 35174: Don't run gulp po commands if po dir is missing

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 7 Jonathan Druart 2023-11-16 08:02:12 UTC
Created attachment 159025 [details] [review]
Bug 35174: Don't run gulp po commands if po dir is missing

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Jonathan Druart 2023-11-16 08:19:00 UTC
Pushed to master for 23.11.00

And the following commit as well:

git rm -r misc/translator/po
git commit -a --author "Koha translators <>" -m"Bug 35174: Remove .po files from Koha"
Comment 9 Jonathan Druart 2023-11-16 08:19:23 UTC
RMaints, ignore this.
Comment 10 Mason James 2023-11-16 10:14:39 UTC
Created attachment 159038 [details] [review]
Bug 35174: update control files for koha-l10n dependency package

to test...

 - apply patch
 - build koha-common package
 - install koha-common package, and confirm koha-l10n package is installed
Comment 11 Fridolin Somers 2023-11-17 07:12:34 UTC
(In reply to Jonathan Druart from comment #9)
> RMaints, ignore this.

OK not backported
Comment 12 Jonathan Druart 2023-11-22 14:39:16 UTC
Pushed to all stable releases.