Attachment 159245 Details for Bug 35366 – Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts exist

[patch] Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts exist

Bug-35366-bug-33948-follow-up-Fix-display-of-old-c.patch (text/plain), 1.63 KB, created by David Nind on 2023-11-24 20:12:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2023-11-24 20:12:09 UTC

Size: 1.63 KB

patch

obsolete

>From 6675644fd02b12d3ac695c34c4a21bce268595b8 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 24 Nov 2023 08:04:16 +0100
>Subject: [PATCH] Bug 35366: (bug 33948 follow-up) Fix display of old checkouts
> if no checkouts exist
>
>Same patch as
>  commit bee2b3d33ed6030b5a63d22148b9955a9897e51d
>  Bug 33949: Fix display of old checkouts if no checkouts exist
>
>But for the staff interface.
>
>"""
>If we pass an empty array from the perl controller, we retrieve an empty
>string from the template, and the merge does not work.
>
>This patch fixes the following bug:
>Pick a patron without checkout history
>Check them an item out and check it in
>=> The table is empty, whereas it should display the item that has been
>checked in.
>"""
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>index 0474968527..0f3cba6542 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
>@@ -43,6 +43,8 @@
> [% INCLUDE 'members-toolbar.inc' %]
> <h1>Circulation history</h1>
> 
>+[% UNLESS checkouts %][% checkouts = [] %][% END %]
>+[% UNLESS old_checkouts %][% old_checkouts = [] %][% END %]
> [% SET all_checkouts = checkouts.merge(old_checkouts) %]
> [% UNLESS Koha.Preference('intranetreadinghistory') %]
>     <div class="dialog alert">Staff members are not allowed to access patron's checkout history</div>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35366: 159224 | 159245 | 159257