=== test plan === 1. do a checkout 2. looks a circulation history of the patron, it's here 3. check in 4. history gets empty [U+1F62E]️ 5. do a checkout 6. history now shows the two checkouts [U+1F62E] History in OPAC is ok.
Created attachment 159224 [details] [review] Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts exist Same patch as commit bee2b3d33ed6030b5a63d22148b9955a9897e51d Bug 33949: Fix display of old checkouts if no checkouts exist But for the staff interface. """ If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. """
Created attachment 159245 [details] [review] Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts exist Same patch as commit bee2b3d33ed6030b5a63d22148b9955a9897e51d Bug 33949: Fix display of old checkouts if no checkouts exist But for the staff interface. """ If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. """ Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159257 [details] [review] Bug 35366: (bug 33948 follow-up) Fix display of old checkouts if no checkouts exist Same patch as commit bee2b3d33ed6030b5a63d22148b9955a9897e51d Bug 33949: Fix display of old checkouts if no checkouts exist But for the staff interface. """ If we pass an empty array from the perl controller, we retrieve an empty string from the template, and the merge does not work. This patch fixes the following bug: Pick a patron without checkout history Check them an item out and check it in => The table is empty, whereas it should display the item that has been checked in. """ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!