Attachment 159387 Details for Bug 35436 – Fix - Bug 35436 - Copy is not translatable in OPAC Search History

[patch] Fix - Bug 35436 - Copy is not translatable in OPAC Search History

Fix---Bug-35436---Copy-is-not-translatable-in-OPAC.patch (text/plain), 1.97 KB, created by Adolfo Rodríguez Taboada on 2023-11-30 10:07:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Adolfo Rodríguez Taboada

Created: 2023-11-30 10:07:06 UTC

Size: 1.97 KB

patch

obsolete

>From ed6b34ccd42ad5082346e6eaa6ac1b944ecf916a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Adolfo=20Rodr=C3=ADguez?= <adolfo.rodriguez@xercode.es>
>Date: Thu, 30 Nov 2023 11:06:27 +0100
>Subject: [PATCH] Fix - Bug 35436 - Copy is not translatable in OPAC Search
> History
>
>The change to the way the table in Search History is handled broke its column definitions, that's why the checkbox column was sortable and the last column was visible when it shouldn't
>
>Test plan
>1 Enter in OPAC Search History in a language other than English and check that Copy is not translated
>2 Apply patch, restart services
>3 Regenerate the templates for that language
>4 Repeat step 1 and check that Copy appears now translated
>---
> .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt      | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>index 7abcb808e8..01543bc29a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>@@ -2,6 +2,7 @@
> [% USE Asset %]
> [% USE Koha %]
> [% USE KohaDates %]
>+[% USE TablesSettings %]
> [% USE AdditionalContents %]
> [% SET OpacNav = AdditionalContents.get( location => "OpacNav", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %]
> [% SET OpacNavBottom = AdditionalContents.get( location => "OpacNavBottom", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %]
>@@ -295,7 +296,7 @@
>         var table = KohaTable(".historyt", {
>             "order": [[ 1, "desc" ]],
>             "dom": '<"top"<"table_entries"><"table_controls"fB>>t',
>-            "columnDefs": [
>+            "aoColumnDefs": [
>                 { "targets": [ 0 ], "sortable": false, "searchable": false },
>                 { "className": 'dtr-control', "orderable": false, "targets": -1 }
>             ],
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35436: 159349 | 159350 | 159387 | 159388 | 159468 | 159663