Created attachment 159349 [details] OPAC Search History Capture Copy in the table of OPAC Search History isn't translatable.
Created attachment 159350 [details] [review] Fix - Bug 35436 - Copy is not translatable in OPAC Search History
With this patch the responsive behavior of the DataTable is buggy: The last column, which is supposed to be hidden at wider browser widths, is always visible. I notice also that the first column (checkboxes) is sortable. It should not be. Please provide a test plan in your commit message!
Created attachment 159387 [details] [review] Fix - Bug 35436 - Copy is not translatable in OPAC Search History The change to the way the table in Search History is handled broke its column definitions, that's why the checkbox column was sortable and the last column was visible when it shouldn't Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated
Created attachment 159388 [details] [review] Fix - Bug 35436 - Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated
Hi Adolfo, I don't see a connection between your patch and the translatability of the string, can you please explain?
This is not intuitive. I noticed that in "your checkout history" Copy is translatable unlike in "your search history". I compared the way the table is created and saw that "your checkout history" uses KohaTable so I changed "your search history" to do the same and now Copy gets translated.
Created attachment 159468 [details] [review] Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 159663 [details] [review] Bug 35436: Copy is not translatable in OPAC Search History Test plan 1 Enter in OPAC Search History in a language other than English and check that Copy is not translated 2 Apply patch, restart services 3 Regenerate the templates for that language 4 Repeat step 1 and check that Copy appears now translated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.01
Backported to 23.05.x for upcoming 23.05.07