Bugzilla – Attachment 159438 Details for
Bug 33646
"Cataloging search" missing important data for not for loan items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33646: Better organize availability in cataloging search
Bug-33646-Better-organize-availability-in-catalogi.patch (text/plain), 5.05 KB, created by
Marcel de Rooy
on 2023-12-01 10:31:15 UTC
(
hide
)
Description:
Bug 33646: Better organize availability in cataloging search
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-12-01 10:31:15 UTC
Size:
5.05 KB
patch
obsolete
>From 7d2519750e917a78c9fe8a8f356dee272af25ba4 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 16 Nov 2023 05:58:53 +0000 >Subject: [PATCH] Bug 33646: Better organize availability in cataloging search >Content-Type: text/plain; charset=utf-8 > >This change adds "Available", "Unavailable", and "Not for loan" >categories in the availability cell of the "cataloging search" >found at /cgi-bin/koha/cataloguing/addbooks.pl > >This change also adds missing location information for the >"Not for loan" items. > >Test plan: >0. Apply the patch >1. Add available, checked out, and not for loan items for a test record >(like "Gairm" in koha-testing-docker) >2. Go to the cataloging search, >http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test >3. Note that the items in the "Location" column now have labels >to differentiate which items are available, unavailable, and not for loan. >4. Note that the "Not for loan" data is similar to the "Available" data > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../prog/en/modules/cataloguing/addbooks.tt | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >index 1c68a871ac..7cd6b78567 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt >@@ -138,8 +138,9 @@ > </p> > [% END %] > </td> >- <td> >+ <td class="availability"> > [% IF ( resultsloo.available_items_loop ) %] >+ <div class="results_available_count">Available:</div> > <span class="available"> > [% FOREACH items_loo IN resultsloo.available_items_loop %] > [% items_loo.count | html %] [% items_loo.branchname | html %] >@@ -155,6 +156,9 @@ > </span> > [% END %] > <span class="unavailable"> >+ [% IF ( resultsloo.onloancount || resultsloo.withdrawncount || resultsloo.itemlostcount || resultsloo.recalledcount || resultsloo.onholdcount ) %] >+ <div class="results_unavailable">Unavailable:</div> >+ [% END %] > [% IF ( resultsloo.onloancount ) %] <span>Checked out ([% resultsloo.onloancount | html %])</span>,<br /> [% END %] > [% IF ( resultsloo.withdrawncount ) %] <span>Withdrawn ([% resultsloo.withdrawncount | html %])</span>,<br /> [% END %] > [% IF ( resultsloo.itemlostcount ) %] <span>Lost ([% resultsloo.itemlostcount | html %])</span><br />[% END %] >@@ -162,9 +166,16 @@ > [% IF ( resultsloo.onholdcount ) %] <span>Waiting on hold ([% resultsloo.onholdcount | html %])</span>[% END %] > </span> > <span class="notforloan"> >- [% IF ( resultsloo.other_items_loop ) %] >+ [% IF ( resultsloo.other_items_loop.size ) %] >+ <div class="results_unavailable">Not for loan:</div> > [% FOREACH items_loo IN resultsloo.other_items_loop %] >- [% IF ( items_loo.notforloan ) %][% items_loo.notforloan | html %] ([% items_loo.count | html %])<br />[% END %] >+ [% IF ( items_loo.notforloan ) %] >+ [% items_loo.count | html %] [% items_loo.branchname | html %] >+ [% IF ( items_loo.location ) %]<span class="shelvingloc">[% items_loo.location | html %]</span>[% END %] >+ [% IF ( items_loo.itemcallnumber ) %][% items_loo.itemcallnumber | html %][% END %] >+ ([% items_loo.notforloan | html %]) >+ <br /> >+ [% END %] > [% END %] > [% END %] > </span> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33646
:
159020
|
159246
|
159437
| 159438