In the "Cataloging search" (ie /cgi-bin/koha/cataloguing/addbooks.pl), the branch name doesn't appear for "Not for loan" items, which makes the display nonsensical when there are many not for loan items for many branches. It's also inconsistent with the "Search results" (ie /cgi-bin/koha/catalogue/search.pl).
Which display do you suggest?
(In reply to Jonathan Druart from comment #1) > Which display do you suggest? The "Search results" display is the better display for sure. It looks like ./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt defines a BLOCK that could be re-used on ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt if it were refactored and moved into an include... Although that's just in terms of the information provided. I'm not sure it would work stylistically...
The same is true for checked out items. No location information is displayed. Only "Checked out (x)"
It's showing up on ours as well! Makes no sense and ALL our materials are not for loan.
I've kept this issue open in my local tracker, but it's very low on my priority list :/
(In reply to Lucas Gass from comment #3) > The same is true for checked out items. No location information is > displayed. Only "Checked out (x)" It looks like the data comes straight from searchResults and is displayed like this: <span class="unavailable"> [% IF ( resultsloo.onloancount ) %] <span>Checked out ([% resultsloo.onloancount | html %])</span>,<br /> [% END %] [% IF ( resultsloo.withdrawncount ) %] <span>Withdrawn ([% resultsloo.withdrawncount | html %])</span>,<br /> [% END %] [% IF ( resultsloo.itemlostcount ) %] <span>Lost ([% resultsloo.itemlostcount | html %])</span><br />[% END %] [% IF ( resultsloo.recalledcount ) %] <span>Waiting to fill recall ([% resultsloo.recalled | html %])</span>[% END %] [% IF ( resultsloo.onholdcount ) %] <span>Waiting on hold ([% resultsloo.onholdcount | html %])</span>[% END %] </span> Whereas for notforloan it's displayed a bit differently. That said, there is a "onloan_items_loop" which could be used to display the items... <span class="notforloan"> [% IF ( resultsloo.other_items_loop ) %] [% FOREACH items_loo IN resultsloo.other_items_loop %] [% IF ( items_loo.notforloan ) %][% items_loo.notforloan | html %] ([% items_loo.count | html %])<br />[% END %] [% END %] [% END %] </span> It's a bit of a mess...
Created attachment 159020 [details] [review] Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data
While I think we should ultimately retire the "Cataloging search", this at least makes it a bit more usable.
Created attachment 159246 [details] [review] Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data Signed-off-by: David Nind <david@davidnind.com>
(In reply to David Cook from comment #8) > While I think we should ultimately retire the "Cataloging search", this at > least makes it a bit more usable. Agreed.
Created attachment 159437 [details] [review] Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159438 [details] [review] Bug 33646: Better organize availability in cataloging search This change adds "Available", "Unavailable", and "Not for loan" categories in the availability cell of the "cataloging search" found at /cgi-bin/koha/cataloguing/addbooks.pl This change also adds missing location information for the "Not for loan" items. Test plan: 0. Apply the patch 1. Add available, checked out, and not for loan items for a test record (like "Gairm" in koha-testing-docker) 2. Go to the cataloging search, http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=test 3. Note that the items in the "Location" column now have labels to differentiate which items are available, unavailable, and not for loan. 4. Note that the "Not for loan" data is similar to the "Available" data Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Moved to enh
There are issues with this patch: - With this patch applied we always have the "Available" sub-heading, even on records with no items. - When one item is "damaged" it will now show, but the "nor for loan" sub-heading will still show. And it's falsely formatted in italic. Possibly inherited? You check for the loop size, but then only items with notforloan are displayed - I haven't tested/checked what other items might be in the loop, but damaged seems to be: + [% IF ( resultsloo.other_items_loop.size ) %] + <div class="results_unavailable">Not for loan:</div> [% FOREACH items_loo IN resultsloo.other_items_loop %] - [% IF ( items_loo.notforloan ) %][% items_loo.notforloan | html %] ([% items_loo.count | html %])<br />[% END %] + [% IF ( items_loo.notforloan ) %] Please fix!
Still intending to come back here David?
(In reply to Martin Renvoize from comment #15) > Still intending to come back here David? Probably not. Something needs to happen here, but I see it as high effort low reward.
Any chance this could be fixed? Thanks.
(In reply to Marie-Luce Laflamme from comment #17) > Any chance this could be fixed? Thanks. I'm happy for someone to takeover my patch, as it's unlikely I'll work on it again. Resetting assignee to default...