Bugzilla – Attachment 159449 Details for
Bug 35460
Unable to add or edit hold rules in circulation rules table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35460: Fix add and edit of hold rules in circulation rules table
0001-Bug-35460-Fix-add-and-edit-of-hold-rules-in.patch (text/plain), 1.73 KB, created by
Emmi Takkinen
on 2023-12-01 13:10:19 UTC
(
hide
)
Description:
Bug 35460: Fix add and edit of hold rules in circulation rules table
Filename:
MIME Type:
Creator:
Emmi Takkinen
Created:
2023-12-01 13:10:19 UTC
Size:
1.73 KB
patch
obsolete
>From 9158531291f8315deb126f7051f840c53c288eec Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Fri, 1 Dec 2023 15:08:48 +0200 >Subject: [PATCH] Bug 35460: Fix add and edit of hold rules in circulation > rules table > >Adding or editing following columns in circulation >rules table didn't work: >- Holds allowed (total) >- Holds allowed (daily) >- Holds per record (count) > >At some point those columns were dropped from list of >saved columns in smart-rules.pl. > >To test: >1. Create new rule or edit existing one. >2. Add or change values in following columns: >- Holds allowed (total) >- Holds allowed (daily) >- Holds per record (count >3. Save rule. >=> Note that columns have value "Unlimited" on them. >If you check database, columns haven't been saved. >4. Apply this patch. >5. Repeat steps 1. to 3. >=> Columns should now have values in them and they >are saved to database. > >Sponsored-by: Koha-Suomi Oy >--- > admin/smart-rules.pl | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl >index b1c7868184..fd20484c9f 100755 >--- a/admin/smart-rules.pl >+++ b/admin/smart-rules.pl >@@ -327,6 +327,9 @@ elsif ( $op eq 'add' ) { > auto_renew => $auto_renew, > no_auto_renewal_after => $no_auto_renewal_after, > no_auto_renewal_after_hard_limit => $no_auto_renewal_after_hard_limit, >+ reservesallowed => $reservesallowed, >+ holds_per_record => $holds_per_record, >+ holds_per_day => $holds_per_day, > onshelfholds => $onshelfholds, > opacitemholds => $opacitemholds, > overduefinescap => $overduefinescap, >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35460
:
159449
|
159452