Adding or editing following columns in circulation rules table doesn't seem to work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) To reproduce: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved.
It seems that bug 8367 dropped those columns at some point from smart-rules.pl and now the saving isn't working.
Hi Emmi, do you have a link to the broken database update? it should have only added a column.
(In reply to Katrin Fischer from comment #2) > Hi Emmi, do you have a link to the broken database update? it should have > only added a column. It's not really a database update that is broken https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158023 If you look changes made to smart-rules.pl variable my $rules, these columns have been dropped from there. I'm currently making a patch for this.
Created attachment 159449 [details] [review] Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy
Thanks Emmi! (just was got scared for a moment there. Still not nice, but not AS evil)
Created attachment 159452 [details] [review] Bug 35460: Fix add and edit of hold rules in circulation rules table Adding or editing following columns in circulation rules table didn't work: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count) At some point those columns were dropped from list of saved columns in smart-rules.pl. To test: 1. Create new rule or edit existing one. 2. Add or change values in following columns: - Holds allowed (total) - Holds allowed (daily) - Holds per record (count 3. Save rule. => Note that columns have value "Unlimited" on them. If you check database, columns haven't been saved. 4. Apply this patch. 5. Repeat steps 1. to 3. => Columns should now have values in them and they are saved to database. Sponsored-by: Koha-Suomi Oy Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Going straight to PQA for this one - it's a small, straightforward change and an important fix
(In reply to Katrin Fischer from comment #5) > Thanks Emmi! > > (just was got scared for a moment there. Still not nice, but not AS evil) Sorry for that :D but yeah, it's not _that_ bad situation but quite nasty still. Those columns are easy to miss since they are at the end of table.
Always good to add the "Depends on:" to help our RMaints finding the right versions for backporting :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.01
Missing dependencies for 23.05.x, no backport.