Attachment 159468 Details for Bug 35436 – Bug 35436: Copy is not translatable in OPAC Search History

[patch] Bug 35436: Copy is not translatable in OPAC Search History

Bug-35436-Copy-is-not-translatable-in-OPAC-Search-.patch (text/plain), 2.87 KB, created by Owen Leonard on 2023-12-01 17:26:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-12-01 17:26:37 UTC

Size: 2.87 KB

patch

obsolete

>From 6f9a87fef4a3839762edd7ff058e8abc102b1452 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Adolfo=20Rodr=C3=ADguez?= <adolfo.rodriguez@xercode.es>
>Date: Thu, 30 Nov 2023 11:12:13 +0100
>Subject: [PATCH] Bug 35436: Copy is not translatable in OPAC Search History
>
>Test plan
>1 Enter in OPAC Search History in a language other than English and
>  check that Copy is not translated
>2 Apply patch, restart services
>3 Regenerate the templates for that language
>4 Repeat step 1 and check that Copy appears now translated
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../bootstrap/en/modules/opac-search-history.tt      | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>index 16d7effb84..01543bc29a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
>@@ -2,6 +2,7 @@
> [% USE Asset %]
> [% USE Koha %]
> [% USE KohaDates %]
>+[% USE TablesSettings %]
> [% USE AdditionalContents %]
> [% SET OpacNav = AdditionalContents.get( location => "OpacNav", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %]
> [% SET OpacNavBottom = AdditionalContents.get( location => "OpacNavBottom", lang => lang, library => logged_in_user.branchcode || default_branch, blocktitle => 0 ) %]
>@@ -284,16 +285,18 @@
> 
> [% BLOCK jsinclude %]
> [% INCLUDE 'datatables.inc' %]
>+[% INCLUDE 'columns_settings.inc' %]
> <script>
> 
>     var MSG_CONFIRM_DELETE_HISTORY = _("Are you sure you want to delete selected search history entries?");
>     $(document).ready(function() {
>         // We show table ordered by descending dates by default
>         // (so that the more recent query is shown first)
>-        $(".historyt").dataTable($.extend(true, {}, dataTablesDefaults, {
>+        var columns_settings = []; // Empty because there are no columns we want to be configurable
>+        var table = KohaTable(".historyt", {
>             "order": [[ 1, "desc" ]],
>             "dom": '<"top"<"table_entries"><"table_controls"fB>>t',
>-            "columnDefs": [
>+            "aoColumnDefs": [
>                 { "targets": [ 0 ], "sortable": false, "searchable": false },
>                 { "className": 'dtr-control', "orderable": false, "targets": -1 }
>             ],
>@@ -305,11 +308,12 @@
>             "responsive": {
>                 "details": { "type": 'column',"target": -1 }
>             },
>-        }));
>+        }, columns_settings);
> 
>         $('a[data-toggle="tab"]').on('shown.bs.tab', function (e) {
>-            $(".historyt").DataTable().responsive.recalc();
>+            table.DataTable().responsive.recalc();
>         });
>+
>         $(".CheckNone").click(function(e){
>             e.preventDefault();
>             var form = $(this).parents("form").get(0);
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35436: 159349 | 159350 | 159387 | 159388 | 159468 | 159663