Bugzilla – Attachment 159697 Details for
Bug 35525
Spelling: SMS is an abbreviation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC
Bug-35525-Fix-spelling-of-SMS-in-aria-labels-for-m.patch (text/plain), 3.46 KB, created by
Katrin Fischer
on 2023-12-10 13:48:10 UTC
(
hide
)
Description:
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-12-10 13:48:10 UTC
Size:
3.46 KB
patch
obsolete
>From d576ed1917a9dd946839d46a503e78d1d3d744c6 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 10 Dec 2023 13:41:46 +0000 >Subject: [PATCH] Bug 35525: Fix spelling of SMS in aria-labels for messaging > in OPAC > >Updates sms to SMS. > >* Apply patch >* Set SMSSendDriver system preference to Email >* Go to the OPAC patron account, messaging tab >* Check some SMS check boxes and save >* Verify that the source code for the checked and unchecked > the aria-label now reads "Select/Unselect SMS messaging" > >Also fixes a mismatched itiva message. >Repeat test plan with TalkingTechItivaPhoneNotification Enabled >and the phone checkboxes. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index 32d5d3f2e2..c22f9ea69e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -94,9 +94,9 @@ > [% IF ( messaging_preference.transport_sms ) %] > <td class="selectcol"> > [% IF ( messaging_preference.transports_sms ) %] >- <input type="checkbox" aria-label="Unselect sms messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" /> >+ <input type="checkbox" aria-label="Unselect SMS messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" /> > [% ELSE %] >- <input type="checkbox" aria-label="Select sms messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" /> >+ <input type="checkbox" aria-label="Select SMS messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" /> > [% END %] > </td> > [% ELSE %] >@@ -138,7 +138,7 @@ > value="itiva" checked="checked" /> > [% ELSE %] > <input type="checkbox" >- aria-label="Select notification by phone" >+ aria-label="Select itiva messaging" > class="itiva" > id="itiva[% messaging_preference.message_attribute_id | html %]" > name="[% messaging_preference.message_attribute_id | html %]" >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35525
:
159697
|
159701
|
159710
|
159953