Created attachment 159697 [details] [review] Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Apply patch * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes.
Created attachment 159701 [details] [review] Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes.
Created attachment 159710 [details] [review] Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 159953 [details] [review] Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC Updates sms to SMS. * Set SMSSendDriver system preference to Email * Go to the OPAC patron account, messaging tab * Check some SMS check boxes and save * Verify that in the source code the aria-label for the checked and unchecked checkboxes reads: sms messaging * Verify that in the source code for the 'days in advance' pull down, the message reads "... receive notice" * Apply patch, restart all * Verify that the source code for the checked and unchecked the aria-label now reads "Select/Unselect SMS messaging" * Verify that the aria-label on the 'days in advance' pull down now reads 'receive the message' Also fixes a mismatched itiva message. Repeat test plan with TalkingTechItivaPhoneNotification Enabled and the phone checkboxes. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Doesn't apply cleanly to 23.05.x, no backport.