Bugzilla – Attachment 159953 Details for
Bug 35525
Spelling: SMS is an abbreviation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC
Bug-35525-Fix-spelling-of-SMS-in-aria-labels-for-m.patch (text/plain), 4.99 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-12-18 11:49:14 UTC
(
hide
)
Description:
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-12-18 11:49:14 UTC
Size:
4.99 KB
patch
obsolete
>From dc0f6c8cb9216a8c61fe2e54000a14fd3d4998cd Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Sun, 10 Dec 2023 13:41:46 +0000 >Subject: [PATCH] Bug 35525: Fix spelling of SMS in aria-labels for messaging > in OPAC > >Updates sms to SMS. > >* Set SMSSendDriver system preference to Email >* Go to the OPAC patron account, messaging tab >* Check some SMS check boxes and save >* Verify that in the source code the aria-label for the > checked and unchecked checkboxes reads: sms messaging >* Verify that in the source code for the 'days in advance' > pull down, the message reads "... receive notice" >* Apply patch, restart all >* Verify that the source code for the checked and unchecked > the aria-label now reads "Select/Unselect SMS messaging" >* Verify that the aria-label on the 'days in advance' pull > down now reads 'receive the message' > >Also fixes a mismatched itiva message. >Repeat test plan with TalkingTechItivaPhoneNotification Enabled >and the phone checkboxes. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index 32d5d3f2e24..3b5d5e95a76 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -78,7 +78,7 @@ > [% ELSIF ( messaging_preference.Auto_Renewals ) %]<span>Auto renewal</span> > [% ELSE %]<span>Unknown</span> [% END %]</td> > [% IF ( messaging_preference.takes_days ) %] >- <td><select class="input-mini" name="[% messaging_preference.message_attribute_id | html %]-DAYS" aria-label="Choose how many days in advance you wish to receive notice"> >+ <td><select class="input-mini" name="[% messaging_preference.message_attribute_id | html %]-DAYS" aria-label="Choose how many days in advance you wish to receive the message"> > [% FOREACH select_day IN messaging_preference.select_days %] > [% IF ( select_day.selected ) %] > <option value="[% select_day.day | html %]" selected="selected">[% select_day.day | html %]</option> >@@ -94,9 +94,9 @@ > [% IF ( messaging_preference.transport_sms ) %] > <td class="selectcol"> > [% IF ( messaging_preference.transports_sms ) %] >- <input type="checkbox" aria-label="Unselect sms messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" /> >+ <input type="checkbox" aria-label="Unselect SMS messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" checked="checked" /> > [% ELSE %] >- <input type="checkbox" aria-label="Select sms messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" /> >+ <input type="checkbox" aria-label="Select SMS messaging" class="pmp_sms" id="sms[% messaging_preference.message_attribute_id | html %]" name="[% messaging_preference.message_attribute_id | html %]" value="sms" /> > [% END %] > </td> > [% ELSE %] >@@ -138,7 +138,7 @@ > value="itiva" checked="checked" /> > [% ELSE %] > <input type="checkbox" >- aria-label="Select notification by phone" >+ aria-label="Select itiva messaging" > class="itiva" > id="itiva[% messaging_preference.message_attribute_id | html %]" > name="[% messaging_preference.message_attribute_id | html %]" >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35525
:
159697
|
159701
|
159710
| 159953