Attachment 16040 Details for Bug 8853 – Bug 8853: Suppress links in basketgroups list

[patch] Bug 8853: Suppress links in basketgroups list

Bug-8853-Suppress-links-in-basketgroups-list.patch (text/plain), 2.60 KB, created by Jonathan Druart on 2013-03-11 16:28:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2013-03-11 16:28:41 UTC

Size: 2.60 KB

patch

obsolete

>From 221e432bf202a402e7afc7332e23eb6c30289741 Mon Sep 17 00:00:00 2001
>From: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
>Date: Sat, 9 Mar 2013 16:15:19 +0100
>Subject: [PATCH] Bug 8853: Suppress links in basketgroups list
>
>In the table listing all closed basketgroups, clicking the name of a
>basketgroup reopen it. To edit an open basketgroup or reopen a closed
>basketgroup, there are specific buttons in "Action" column. So the link
>around basketgroup name is an UX problem. This patch suppress the link
>around basketgroup name, in both "closed" and "open" tab.
>
>To test :
>1. create some closed and open basketgroups
>2. check links are not showing anymore
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt |    8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>index d8be02a..b0a7a92 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>@@ -275,11 +275,11 @@ function yuiToolbar() {
> 			[% FOREACH basketgroup IN basketgroups %]
> 				[% UNLESS ( basketgroup.closed ) %]
> 					<tr>
>-						<td><a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% basketgroup.booksellerid %]&amp;basketgroupid=[% basketgroup.id %]">[% IF ( basketgroup.name ) %]
>+						<td>[% IF ( basketgroup.name ) %]
> 													[% basketgroup.name %]
> 												[% ELSE %]
> 													Basket group no. [% basketgroup.id %]
>-												[% END %]</a>
>+												[% END %]
> 						</td>
> 							<td>
>                               <span>
>@@ -306,11 +306,11 @@ function yuiToolbar() {
> 				[% IF ( basketgroup.closed ) %]
> 				<tr>
> 				<td>
>-                    <a href="/cgi-bin/koha/acqui/basketgroup.pl?op=reopen&amp;booksellerid=[% basketgroup.booksellerid %]&amp;basketgroupid=[% basketgroup.id %]">[% IF ( basketgroup.name ) %]
>+                                     [% IF ( basketgroup.name ) %]
> 											[% basketgroup.name %]
> 										[% ELSE %]
> 											Basket group no. [% basketgroup.id %]
>-										[% END %]</a>
>+										[% END %]
> 					</td>
> 					<td>
> 							<form action="/cgi-bin/koha/acqui/basketgroup.pl" method="get"><input type="hidden" name="op" value="reopen" /><input type="hidden" name="booksellerid" value="[% basketgroup.booksellerid %]" /><input type="hidden" name="basketgroupid" value="[% basketgroup.id %]" /><input type="submit" value="Reopen" /></form>
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 8853: 15998 | 16038 | 16040