Attachment 160782 Details for Bug 35567 – Bug 35567: Prevent translation of Host-item in "Show analytics" link

[patch] Bug 35567: Prevent translation of Host-item in "Show analytics" link

Bug-35567-Prevent-translation-of-Host-item-in-Show.patch (text/plain), 3.46 KB, created by Victor Grousset/tuxayo on 2024-01-10 18:34:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-01-10 18:34:24 UTC

Size: 3.46 KB

patch

obsolete

>From 6e88cd53c4b9791064131e450f8706ad47eb7f99 Mon Sep 17 00:00:00 2001
>From: Kevin Carnes <kevin.carnes@ub.lu.se>
>Date: Thu, 14 Dec 2023 10:47:40 +0100
>Subject: [PATCH] Bug 35567: Prevent translation of Host-item in "Show
> analytics" link
>
>The "Show analytics" link is built using text which can be translated.
>
>The following languages have already translated Host-item:
>fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE
>
>To test:
> 1. Install one of the affected languages:
>    koha-translate --install sv-SE --dev kohadev
> 2. Modify and save the following system preferences:
>    language: enable the language
>    OPACLanguages: enable the language
>    opaclanguagesdisplay: Allow
>    EasyAnalyticalRecords: Show
> 3. View a record with holdings and copy the barcode of one the items
> 4. Select the Edit dropdown menu above the record details and click
>    "Link to host record"
> 5. Paste the barcode, click Select, and click OK
> 6. Return to Normal view of the record and reload the page
> 7. There should now be a "Show analytics" link
> 8. Hover over the link and note that the link contains "Host-item"
> 9. Switch to one of the affected languages and note that "Host-item" is
>    translated
>10. View the record in the OPAC and confirm that the link is also translated
>11. Apply the patch
>12. Update the affected language:
>    koha-translate --update sv-SE --dev kohadev
>13. Restart Koha (restart_all)
>14. Notice that the links are no longer translated
>15. Sign off
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl    | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index d57a8846be..48439f3a24 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -222,7 +222,7 @@
>                     </xsl:when>
>                     <xsl:otherwise>
>                         <xsl:variable name="title_query">
>-                            <xsl:text>Host-item:(</xsl:text>
>+                            <xsl:value-of select="'Host-item:('"/>
>                             <xsl:call-template name="quote_search_term">
>                                 <xsl:with-param name="term"><xsl:value-of select="marc:datafield[@tag=245]/marc:subfield[@code='a']"/></xsl:with-param>
>                             </xsl:call-template>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 6b1f6e3f2f..3fe783b615 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -264,7 +264,7 @@
>                     </xsl:when>
>                     <xsl:otherwise>
>                         <xsl:variable name="title_query">
>-                            <xsl:text>Host-item:(</xsl:text>
>+                            <xsl:value-of select="'Host-item:('"/>
>                             <xsl:call-template name="quote_search_term">
>                                 <xsl:with-param name="term"><xsl:value-of select="marc:datafield[@tag=245]/marc:subfield[@code='a']"/></xsl:with-param>
>                             </xsl:call-template>
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 35567: 159819 | 159914 | 160782