The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE
Created attachment 159819 [details] [review] Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off
Created attachment 159914 [details] [review] Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 160782 [details] [review] Bug 35567: Prevent translation of Host-item in "Show analytics" link The "Show analytics" link is built using text which can be translated. The following languages have already translated Host-item: fa-Arab, fi-FI, nl-NL, pt-BR, ru-RU, sv-SE To test: 1. Install one of the affected languages: koha-translate --install sv-SE --dev kohadev 2. Modify and save the following system preferences: language: enable the language OPACLanguages: enable the language opaclanguagesdisplay: Allow EasyAnalyticalRecords: Show 3. View a record with holdings and copy the barcode of one the items 4. Select the Edit dropdown menu above the record details and click "Link to host record" 5. Paste the barcode, click Select, and click OK 6. Return to Normal view of the record and reload the page 7. There should now be a "Show analytics" link 8. Hover over the link and note that the link contains "Host-item" 9. Switch to one of the affected languages and note that "Host-item" is translated 10. View the record in the OPAC and confirm that the link is also translated 11. Apply the patch 12. Update the affected language: koha-translate --update sv-SE --dev kohadev 13. Restart Koha (restart_all) 14. Notice that the links are no longer translated 15. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Backported to 23.05.x for upcoming 23.05.08