Attachment 161135 Details for Bug 34431 – Bug 34431: (QA follow-up) Fix duplicate backend options

[patch] Bug 34431: (QA follow-up) Fix duplicate backend options

Bug-34431-QA-follow-up-Fix-duplicate-backend-optio.patch (text/plain), 1.75 KB, created by Tomás Cohen Arazi (tcohen) on 2024-01-18 12:59:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-01-18 12:59:07 UTC

Size: 1.75 KB

patch

obsolete

>From 3653cee7f0c0baecd5ed8de48f6cf309ad8aba3d Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Thu, 31 Aug 2023 08:57:20 +0000
>Subject: [PATCH] Bug 34431: (QA follow-up) Fix duplicate backend options
>
>Prevent adding backend option if the option already exists
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>index 79d6e2b4791..456899abfbf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js
>@@ -523,10 +523,12 @@ $(document).ready(function() {
>             },
>             success: function(backends){
>                 backends.sort((a, b) => a.ill_backend_id.localeCompare(b.ill_backend_id)).forEach(function(backend) {
>-                    $('#illfilter_backend').append(
>-                        '<option value="' + backend.ill_backend_id  +
>-                        '">' + backend.ill_backend_id +  '</option>'
>-                    );
>+                    if( $('#illfilter_backend option[value=' + backend.ill_backend_id + ']').length == 0 ){
>+                        $('#illfilter_backend').append(
>+                            '<option value="' + backend.ill_backend_id  +
>+                            '">' + backend.ill_backend_id +  '</option>'
>+                        );
>+                    }
>                 });
> 
>                 let all_existing_statuses = [];
>@@ -559,7 +561,6 @@ $(document).ready(function() {
>                         }
>                     }
>                 )
>-
>             }
>         });
>     }
>-- 
>2.43.0

Actions: View | Diff | Splinter Review

Attachments on bug 34431: 154034 | 154035 | 154036 | 154037 | 154289 | 154290 | 154291 | 154292 | 154301 | 154405 | 154406 | 154407 | 154408 | 154409 | 154410 | 154999 | 161104 | 161105 | 161106 | 161107 | 161108 | 161109 | 161110 | 161129 | 161130 | 161131 | 161132 | 161133 | 161134 | 161135