Bug 34431 - Distinguish between status and status_alias in ILL UI
Summary: Distinguish between status and status_alias in ILL UI
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Pedro Amorim
QA Contact:
URL:
Keywords:
: 33685 (view as bug list)
Depends on: 34223
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-27 11:12 UTC by Pedro Amorim
Modified: 2023-10-30 09:06 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 34431: Add 'type' to existing_statuses method (1.23 KB, patch)
2023-07-28 10:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Distinguish status from status_alias in filter dropdown (2.63 KB, patch)
2023-07-28 10:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Distinguish status from status_alias in table column (2.07 KB, patch)
2023-07-28 10:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Update tests (1.27 KB, patch)
2023-07-28 10:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Allow for x-koha-embed in ill/backends endpoint (1.95 KB, patch)
2023-08-04 16:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Show both status and status_alias - if exists - in table column (2.00 KB, patch)
2023-08-04 16:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Add a status_alias filter input, if any status_alias exist (9.34 KB, patch)
2023-08-04 16:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Update tests (1.27 KB, patch)
2023-08-04 16:07 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Add status and status_alias filters to clear (1.01 KB, patch)
2023-08-07 10:06 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Add 'type' to existing_statuses method (1.28 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Allow for x-koha-embed in ill/backends endpoint (2.00 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Show both status and status_alias - if exists - in table column (2.05 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Add a status_alias filter input, if any status_alias exist (9.39 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Update tests (1.32 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: Add status and status_alias filters to clear (1.06 KB, patch)
2023-08-14 15:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 34431: (QA follow-up) Fix duplicate backend options (1.69 KB, patch)
2023-08-31 08:57 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2023-07-27 11:12:08 UTC
At the moment, we're concating status and status_alias in the ILL left filters.
We also have our own custom logic of what to present in the status table column, i.e. if a status_alias exists, we show that over status.

This may cause confusing as some users are filtering for status, but table is showing status_alias.

We need to find a way to make it obvious which status a request is at, and which status_alias (if any) is at.
Comment 1 Pedro Amorim 2023-07-28 10:23:53 UTC
Created attachment 154034 [details] [review]
Bug 34431: Add 'type' to existing_statuses method
Comment 2 Pedro Amorim 2023-07-28 10:23:55 UTC
Created attachment 154035 [details] [review]
Bug 34431: Distinguish status from status_alias in filter dropdown

Add a new optgroup in status dropdown
Comment 3 Pedro Amorim 2023-07-28 10:23:58 UTC
Created attachment 154036 [details] [review]
Bug 34431: Distinguish status from status_alias in table column

status now always displays. status_alias shows after in italic bold if exists
Comment 4 Pedro Amorim 2023-07-28 10:24:00 UTC
Created attachment 154037 [details] [review]
Bug 34431: Update tests
Comment 5 Pedro Amorim 2023-07-28 10:44:10 UTC
The following command will (hopefully) reset your ILL data and create 10k fake ILL requests (run this in DEV KTD only).

1) BEFORE APPLYING PATCH, on an empty k-t-d, run:
bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev-data.sh)
2) Pet a cat
3) Visit /cgi-bin/koha/admin/authorised_values.pl add search for "alias", click on ILL_STATUS_ALIAS
4) Click on the "New authorized value for ILL_STATUS_ALIAS" button and add "alias_code" in authorized value and "Alias Description" in Description
5) Visit /cgi-bin/koha/ill/ill-requests.pl and click "Manage request" on a FreeForm request, click "Edit request"
6) Edit the Status and select "Alias Description", click "Submit"
7) Visit /cgi-bin/koha/ill/ill-requests.pl and select FreeForm on the "Backend:" left-side filter
8) Notice how "Status Description" status_alias is now there, mixed with all the other "real" statuses. Click on it and filter on it. Confirm it works
9) Notice the table displays "Status Description" on the "Status" table column

10) Apply patch
11) Repeat 7) Notice how "Status Description" now shows under a new optgroup "Status aliases"
12) Notice the table nows displays whatever status the request has, followed by the "Status Description" status_alias in italic bold
Comment 6 Pedro Amorim 2023-08-04 10:18:51 UTC
I'm going to implement this differently.
Comment 7 Pedro Amorim 2023-08-04 16:07:35 UTC
Created attachment 154289 [details] [review]
Bug 34431: Allow for x-koha-embed in ill/backends endpoint
Comment 8 Pedro Amorim 2023-08-04 16:07:38 UTC
Created attachment 154290 [details] [review]
Bug 34431: Show both status and status_alias - if exists - in table column
Comment 9 Pedro Amorim 2023-08-04 16:07:41 UTC
Created attachment 154291 [details] [review]
Bug 34431: Add a status_alias filter input, if any status_alias exist

This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected.
Comment 10 Pedro Amorim 2023-08-04 16:07:44 UTC
Created attachment 154292 [details] [review]
Bug 34431: Update tests
Comment 11 Pedro Amorim 2023-08-07 10:06:01 UTC
Created attachment 154301 [details] [review]
Bug 34431: Add status and status_alias filters to clear
Comment 12 Pedro Amorim 2023-08-14 15:55:31 UTC
Created attachment 154405 [details] [review]
Bug 34431: Add 'type' to existing_statuses method

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 13 Pedro Amorim 2023-08-14 15:55:34 UTC
Created attachment 154406 [details] [review]
Bug 34431: Allow for x-koha-embed in ill/backends endpoint

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 14 Pedro Amorim 2023-08-14 15:55:37 UTC
Created attachment 154407 [details] [review]
Bug 34431: Show both status and status_alias - if exists - in table column

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 15 Pedro Amorim 2023-08-14 15:55:40 UTC
Created attachment 154408 [details] [review]
Bug 34431: Add a status_alias filter input, if any status_alias exist

This patch also makes it so that the status input filter is enabled by default, and shows all existing statuses by default, or all existing statuses for a specific backend, if and when selected.

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 16 Pedro Amorim 2023-08-14 15:55:42 UTC
Created attachment 154409 [details] [review]
Bug 34431: Update tests

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 17 Pedro Amorim 2023-08-14 15:55:45 UTC
Created attachment 154410 [details] [review]
Bug 34431: Add status and status_alias filters to clear

Signed-off-by: Stephen Graham <s.graham4@herts.ac.uk>
Comment 18 Pedro Amorim 2023-08-31 08:57:30 UTC
Created attachment 154999 [details] [review]
Bug 34431: (QA follow-up) Fix duplicate backend options

Prevent adding backend option if the option already exists
Comment 19 Pedro Amorim 2023-10-30 09:06:58 UTC
*** Bug 33685 has been marked as a duplicate of this bug. ***