Attachment 161344 Details for Bug 34647 – Bug 34647: Replace name attributes with ids

[patch] Bug 34647: Replace name attributes with ids

Bug-34647-Replace-name-attributes-with-ids.patch (text/plain), 6.30 KB, created by Matt Blenkinsop on 2024-01-24 15:14:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-01-24 15:14:55 UTC

Size: 6.30 KB

patch

obsolete

>From 9e8b47959a68293b79d40f77c07ec02d4202435e Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 24 Jan 2024 15:08:56 +0000
>Subject: [PATCH] Bug 34647: Replace name attributes with ids
>
>This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch
>
>Test plan:
>1) Navigate to each page where the link has been amended
>2) Check that the link still works as expected
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt  | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt  | 4 ++--
> .../intranet-tmpl/prog/en/modules/reports/catalogue_out.tt    | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt         | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt  | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>index b39f9d4795d..d4dc6a2d458 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>@@ -79,7 +79,7 @@
>                 [% ELSE %]
>                     <h2 class="suppliername inactive">
>                 [% END %]
>-                        <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]">
>+                        <a id="vendor[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]">
>                             [% IF (supplier.name) %]
>                                 [% supplier.name | html %]
>                             [% ELSE %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>index 18182563286..76fe1fd9608 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
>@@ -243,7 +243,7 @@
>                                                 </td>
>                                                 <td>
>                                                     [% IF note.defined && note != '' %]
>-                                                        <a name="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a>
>+                                                        <a id="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a>
>                                                     [% ELSE %]<span>&nbsp;</span>[% END %]
>                                                 </td>
>                                                 <td>
>@@ -1497,7 +1497,7 @@
>                     var current_column = $("#edit_row td:eq("+i+")");
>                     if ( i == 3 ) {
>                         // specific processing for the Note column
>-                        var note = $(this).find("a[name='viewnote']").data("content");
>+                        var note = $(this).find("a[id='viewnote']").data("content");
>                         $(current_column).find("input[type='text']").val(note);
>                     } else if ( i == 9 ) {
>                         // specific processing for Hard due date
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>index 6194de328a9..feaa023278c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt
>@@ -81,7 +81,7 @@
> 
>                         [% IF ( mainloo.looptables ) %]
>                             <div class="page-section">
>-                                <h3><a name="summary" id="summary"></a>Summary</h3>
>+                                <h3><a id="summary"></a>Summary</h3>
>                                 <table id="summary_table">
>                                     <tr>
>                                         <th>Group</th>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>index 8e616f02a78..8d2a88e3aeb 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
>@@ -94,7 +94,7 @@
>                             [% IF ( news_item ) %]
>                                 [% koha_new.title | html %]
>                             [% ELSE %]
>-                                <a name="newsitem[% koha_new.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.id | uri %]">[% koha_new.title | html %]</a>
>+                                <a id="newsitem[% koha_new.id | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.id | uri %]">[% koha_new.title | html %]</a>
>                             [% END %]
>                         </h4>
>                         <div class="newsbody">[% koha_new.content | $raw %]</div>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 978c592b676..986448629be 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -978,7 +978,7 @@
>                                         <ol class="attributes_table">
>                                             [% FOREACH pa IN pa_class.items %]
>                                                 [% FOREACH pa_value IN pa.values %]
>-                                                    [% IF loop.first %]<a name="patron-attr-start-[% pa.type.code | html %]"></a>[% END %]
>+                                                    [% IF loop.first %]<a id="patron-attr-start-[% pa.type.code | html %]"></a>[% END %]
>                                                     [% form_id = 'patron-attr-' _ Math.int( Math.rand(1000000) ) %]
>                                                     <li data-category_code="[% pa.type.category_code | html %]">
>                                                         [% IF pa.type.mandatory && pa.type.opac_editable %]
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 34647: 161344 | 161345 | 161354 | 161355 | 161356 | 161422 | 161425 | 161432 | 161433 | 161434