Looks like since HTML5, attribute "name" on tag <a> is obsolete : https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conforming-features We have a few of them : koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt: <a name="[% supplier.booksellerid | html %]" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% supplier.booksellerid | uri %]"></a> koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: <a name="viewnote" data-toggle="popover" title="Note" data-content="[% note | html %]" data-placement="top" data-trigger="hover">View note</a> koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt: <h3><a name="summary" id="summary"></a>Summary</h3> koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt: <a name="modaction"></a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt: <a name="newsitem[% koha_new.idnew | html %]" href="/cgi-bin/koha/opac-main.pl?news_id=[% koha_new.idnew | uri %]">[% koha_new.title | html %]</a> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt: [% IF loop.first %]<a name="patron-attr-start-[% pa.type.code | html %]"></a>[% END %] How should we replace ? Some may be not uniq so can't be an id. Maybe an accessibility issue.
(In reply to Fridolin Somers from comment #0) > How should we replace ? > Some may be not uniq so can't be an id. I'd say a class.
But currently this allows to have an anchor on it. For example opac-main.pl#newsitem1 A class will break this. Maybe in this case use an id.
(In reply to Fridolin Somers from comment #2) > But currently this allows to have an anchor on it. > For example opac-main.pl#newsitem1 > A class will break this. > > Maybe in this case use an id. Ah yes. That would be an issue for that particular case. You could cheat with Javascript as well but yeah maybe an ID...
Created attachment 161344 [details] [review] Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected
Created attachment 161345 [details] [review] Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action
Created attachment 161354 [details] [review] Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 161355 [details] [review] Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 161356 [details] [review] Bug 35894: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused.
The bug number is wrong on the follow-up patch, should that patch be on bug 35894 or does it need re-numbering?
Created attachment 161422 [details] [review] Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused.
(In reply to Matt Blenkinsop from comment #9) > The bug number is wrong on the follow-up patch Sorry about that!
Created attachment 161425 [details] [review] Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 161432 [details] [review] Bug 34647: Replace name attributes with ids This patch replaces name attributes on <a> tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161433 [details] [review] Bug 34647: Delete unnecessary anchor tag This patch removes an anchor tag from the form that does not seem to serve any purpose. The form has an id attribute and it is this that appears to be used for navigation to and displaying the form. Test plan: 1) Navigate to Cataloging > marc modification templates 2) Add a new template or edit an existing one 3) The form to add a new action should be displayed when either the "New action" button is clicked or you select to edit an existing action Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 161434 [details] [review] Bug 34647: (follow-up) Minor fixes This patch fixes the functionality of the <select> menu for jumping to a particular vendor, "Choose a vendor in the list to jump directly to the right place." The patch also removes the empty anchor tag on the "Items with no checkouts" report. It appears to be unused. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great to see these going through, thanks Matt. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Backported to 23.05.x for upcoming 23.05.09