Attachment 161361 Details for Bug 35373 – Bug 35373: Remove false FIXME comment from gather_print_notices.pl

[patch] Bug 35373: Remove false FIXME comment from gather_print_notices.pl

Bug-35373-Remove-false-FIXME-comment-from-gatherpr.patch (text/plain), 1.24 KB, created by Brendan Lawlor on 2024-01-24 19:41:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Brendan Lawlor

Created: 2024-01-24 19:41:26 UTC

Size: 1.24 KB

patch

obsolete

>From 393fc9d26d8319178be737a926bba5647a0a39a0 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 12 Jan 2024 23:23:57 +0000
>Subject: [PATCH] Bug 35373: Remove false FIXME comment from
> gather_print_notices.pl
>
>Removes a FIXME line mentioning bug 8000 that implemented
>SendAllEmailsTo. But the note was added to the "From" line
>and the "To" address is taken from a command line parameter.
>
>To test:
>* Review change carefully
>
>Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
>---
> misc/cronjobs/gather_print_notices.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/cronjobs/gather_print_notices.pl b/misc/cronjobs/gather_print_notices.pl
>index 7df736354f..f3d32cb6b8 100755
>--- a/misc/cronjobs/gather_print_notices.pl
>+++ b/misc/cronjobs/gather_print_notices.pl
>@@ -128,7 +128,7 @@ if ( @emails ) {
>             {
>                 directory => $output_directory,
>                 files     => $files,
>-                from      => C4::Context->preference('KohaAdminEmailAddress'),    # Should be replaced if bug 8000 is pushed
>+                from      => C4::Context->preference('KohaAdminEmailAddress'),
>                 to        => $email,
>                 transport => $transport,
>             }
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35373: 161012 | 161361 | 161426