misc/cronjobs/gather_print_notices.pl has this: directory => $output_directory, files => $files, from => C4::Context->preference('KohaAdminEmailAddress'), # Should be replaced if bug 8000 is pushed to => $email, transport => $transport, Bug 8000 was pushed in 2019, but seems related to the "to" address, not the "from": "This enhancement adds a system preference 'SendAllEmailsTo' which, when populated with a valid email address, will redirect all outgoing mail from Koha to this address. This feature is intended for use during testing/setup of Koha, to prevent spamming users." So maybe the code changed from underneath the comment? Seems like we can remove this comment to avoid future confusion?
Created attachment 161012 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully
Created attachment 161361 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 161426 [details] [review] Bug 35373: Remove false FIXME comment from gather_print_notices.pl Removes a FIXME line mentioning bug 8000 that implemented SendAllEmailsTo. But the note was added to the "From" line and the "To" address is taken from a command line parameter. To test: * Review change carefully Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I don't think the FIXME as it stands ever made sense.. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.03
Backported to 23.05.x for upcoming 23.05.09