Bugzilla – Attachment 161449 Details for
Bug 35535
Cancel hold -button does not work in pop-up (Hold found, item is already waiting)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35535: Allow for cancellation of holds with or without a reason
Bug-35535-Allow-for-cancellation-of-holds-with-or-.patch (text/plain), 2.92 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-01-25 16:57:38 UTC
(
hide
)
Description:
Bug 35535: Allow for cancellation of holds with or without a reason
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-01-25 16:57:38 UTC
Size:
2.92 KB
patch
obsolete
>From 70ebd5376870a63df1817a6801caff17e913ca89 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 17 Jan 2024 15:45:53 +0000 >Subject: [PATCH] Bug 35535: Allow for cancellation of holds with or without a > reason > >TO TEST: >1. Have a waiting hold on a particular barcode >2. Have at least 1 HOLD_CANCELLATION auth value >3. Check in the barcode and try to cancel the hold on the modal while > selecting a reason. >=> SUCCESS: You can cancel a hold when selecting a reason. >4. Repeat 1-3 but not selecting any reason. >=> SUCCESS: Hold cancelled correctly. >5. Delete all HOLD_CANCELLATION auth values. >6. Repeat Try 1-3 >=> SUCCESS: No reason displayed >=> FAIL: Cancelling does nothing. There's an error in the browser > inspector >7. Apply this patch >8. Repeat 1-3 >=> SUCCESS: No reason displayed >=> SUCCESS: Cancelling works >9. Sign off :-D > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Edit: amended the test plan to make it clearer >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 2abde7f9c5a..cbf476b0d36 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -705,7 +705,7 @@ > [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %] > [% IF hold_cancellation.count %] > <select name="cancellation-reason" id="cancellation-reason"> >- <option value="NULL">No reason given</option> >+ <option value="">No reason given</option> > [% FOREACH reason IN hold_cancellation %] > <option value="[% reason.authorised_value | html %]">[% reason.lib | html %]</option> > [% END %] >@@ -1562,7 +1562,11 @@ > this.form.submit(); > }); > $('.cancel-hold').on("click",function(e){ >- let cancel_reason = document.getElementById('cancellation-reason').value; >+ let cancel_form = document.getElementById('cancellation-reason'); >+ let cancel_reason = ''; >+ if ( cancel_form ) { >+ cancel_reason = cancel_form.value; >+ } > this.form.cancel_reserve.value = 1; > this.form.cancel_reason.value = cancel_reason; > this.form.submit(); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35535
:
161072
|
161112
|
161113
| 161449