Bugzilla – Attachment 161455 Details for
Bug 35351
Adjust basket details template to avoid showing empty page-section
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35351: Adjust basket details template to avoid showing empty page-section
Bug-35351-Adjust-basket-details-template-to-avoid-.patch (text/plain), 2.85 KB, created by
Emily Lamancusa (emlam)
on 2024-01-25 18:00:55 UTC
(
hide
)
Description:
Bug 35351: Adjust basket details template to avoid showing empty page-section
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2024-01-25 18:00:55 UTC
Size:
2.85 KB
patch
obsolete
>From 48c4360c6b0ed9969124faa398dcb1e1a7afe4f6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 16 Nov 2023 14:12:17 +0000 >Subject: [PATCH] Bug 35351: Adjust basket details template to avoid showing > empty page-section > >This patch makes a minor change to the markup of the basket details page >so that we don't display an empty div.page-section when there are no >orders. > >Note: This patch includes whitespace changes, so please ignore >whitespace when viewing the diff. > >To test, apply the patch and go to Acquisitions. > >- Search for a vendor and add a basket if necessary. >- View the details of an empty basket. >- Under the "General information" or "Settings" sections there should be > no empty white box. >- View the details of a basket which has orders (using the "Add to > basket" process if necessary). > - Orders should be displayed correctly. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >index 129567a290..197bcd2712 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >@@ -454,8 +454,8 @@ > </div> > [% END %] > >- <div id="acqui_basket_content" class="page-section"> >- [% IF ( books_loop ) %] >+ [% IF ( books_loop ) %] >+ <div id="acqui_basket_content" class="page-section"> > <h2>Orders</h2> > <table id="orders"> > <thead> >@@ -727,9 +727,9 @@ > [% END %] > </tbody> > </table> <!-- /#orders --> >- [% END # / IF ( books_loop ) %] >- [% IF ( listincgst ) %]<small class="highlight">** Vendor's listings already include tax.</small>[% END %] >- </div> <!-- /#acqui_basket_content --> >+ [% IF ( listincgst ) %]<small class="highlight">** Vendor's listings already include tax.</small>[% END %] >+ </div> <!-- /#acqui_basket_content --> >+ [% END # / IF ( books_loop ) %] > > [% IF (cancelledorders_loop) %] > <div id="cancelledorders" class="page-section"> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35351
:
159052
|
159719
| 161455