Bugzilla – Attachment 161575 Details for
Bug 34913
Upgrade DataTables from 1.10.18 to 1.13.6
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34913: Fix perlcritic for VirtualShelves.pm
Bug-34913-Fix-perlcritic-for-VirtualShelvespm.patch (text/plain), 935 bytes, created by
Jonathan Druart
on 2024-01-29 09:42:43 UTC
(
hide
)
Description:
Bug 34913: Fix perlcritic for VirtualShelves.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-01-29 09:42:43 UTC
Size:
935 bytes
patch
obsolete
>From fbc58d5359c67e98a283d0e313c49cc5eae99b3e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 29 Jan 2024 10:41:56 +0100 >Subject: [PATCH] Bug 34913: Fix perlcritic for VirtualShelves.pm > >C4/Utils/DataTables/VirtualShelves.pm: "@order_by" is declared but not used at line 86, column 9. Unused variables clutter code and make it harder to read. (Severity: 3) >--- > C4/Utils/DataTables/VirtualShelves.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/Utils/DataTables/VirtualShelves.pm b/C4/Utils/DataTables/VirtualShelves.pm >index 8100a65591d..2c4c1628e18 100644 >--- a/C4/Utils/DataTables/VirtualShelves.pm >+++ b/C4/Utils/DataTables/VirtualShelves.pm >@@ -83,7 +83,6 @@ sub search { > > > if ($order_by) { >- my @order_by; > $order_by =~ s|shelfnumber|vs.shelfnumber|; > my @sanitized_orderbys; > for my $order ( split ',', $order_by ) { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34913
:
156480
|
157511
|
157725
|
157726
|
157729
|
158229
| 161575