Bugzilla – Attachment 162589 Details for
Bug 36140
Wrong for attribute on Invoice number: label in invoice.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36140: Correct label for attribute invoice.tt
Bug-36140-Correct-label-for-attribute-invoicett.patch (text/plain), 1.92 KB, created by
Martin Renvoize (ashimema)
on 2024-02-29 10:42:01 UTC
(
hide
)
Description:
Bug 36140: Correct label for attribute invoice.tt
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-02-29 10:42:01 UTC
Size:
1.92 KB
patch
obsolete
>From fbab2d3a3e8197d774e46905e03e5ea71c287571 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 20 Feb 2024 23:19:01 +0000 >Subject: [PATCH] Bug 36140: Correct label for attribute invoice.tt > >To test: >1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. >2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) >3. Apply patch and look again, the attribute should correctly be invoicenumber. > >Alternatively, just look at the diff of this trivial change. :) > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >index 267581e4c65..0e89ac55ec2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt >@@ -65,10 +65,10 @@ > <ol> > <li> > [% IF readonly %] >- <label for="shipmentdate">Invoice number:</label> >+ <label for="invoicenumber">Invoice number:</label> > [% invoicenumber | html %] > [% ELSE %] >- <label for="shipmentdate" class="required">Invoice number:</label> >+ <label for="invoicenumber" class="required">Invoice number:</label> > <input type="text" id="invoicenumber" name="invoicenumber" value="[% invoicenumber | html %]" class="required" required="required"/> > <span class="required">Required</span> > [% END %] >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36140
:
162311
|
162518
| 162589