The Invoice label is `<label for="shipmentdate">Invoice number:</label>` when it should be `<label for="invoicenumber">Invoice number:</label>`
Created attachment 162311 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :)
Followed test plan as outlined. Confirmed <label for="shipmentdate">Invoice number:</label> in html when viewing an invoice. Applied patch in Koha Testing Docker. Restarted Apache. Cleared browser cached files. Navigated to invoice and inspected page. Still seeing <label for="shipmentdate">Invoice number:</label>.
Created attachment 162518 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :)
Created attachment 162589 [details] [review] Bug 36140: Correct label for attribute invoice.tt To test: 1. Go to /cgi-bin/koha/acqui/invoice.pl?invoiceid=X where X is the invoice number. 2. Look at the Invoice number with your dev tools, the for attribute is wrong. ( shippingdate ) 3. Apply patch and look again, the attribute should correctly be invoicenumber. Alternatively, just look at the diff of this trivial change. :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Obvious correction of a copy/paste. Works as intended.. Straight to PQA.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.04
Backported to 23.05.x for upcoming 23.05.10