Bugzilla – Attachment 162768 Details for
Bug 36224
It looks like spsuggest functionality was removed years ago, but the templates still refer to it
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36224: Remove unused spsuggest from templates
Bug-36224-Remove-unused-spsuggest-from-templates.patch (text/plain), 2.90 KB, created by
Lucas Gass (lukeg)
on 2024-03-05 16:03:10 UTC
(
hide
)
Description:
Bug 36224: Remove unused spsuggest from templates
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-03-05 16:03:10 UTC
Size:
2.90 KB
patch
obsolete
>From ba1228b191abe345fdcb1cff93acafad25d59b1a Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 5 Mar 2024 16:00:39 +0000 >Subject: [PATCH] Bug 36224: Remove unused spsuggest from templates > >To test: >-APPLY PATCH >-Review the OPAC results and staff interface results pages. >-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts! >--- > .../prog/en/modules/catalogue/results.tt | 12 ------------ > .../opac-tmpl/bootstrap/en/modules/opac-results.tt | 10 ---------- > 2 files changed, 22 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >index 058961463a..110d6a7472 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt >@@ -79,18 +79,6 @@ > <div class="col-sm-8"> > [% END %] > >- [% IF ( koha_spsuggest ) %] >- <div style="font-size: 12px;">Did you mean: >- <ul style="list-style: none;"> >- [% FOREACH SPELL_SUGGES IN SPELL_SUGGEST %] >- <li> >- <a href="/cgi-bin/koha/catalogue/search.pl?q=[% SPELL_SUGGES.spsuggestion | uri %]">[% SPELL_SUGGES.spsuggestion | html %]</a> >- </li> >- [% END %] >- </ul> >- </div> >- [% END %] >- > [% IF ( total ) %] > > <h3> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 043b1bbc69..6d3c34c0a9 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -126,16 +126,6 @@ > <div id="didyoumean">Not what you expected? Check for <a href="/cgi-bin/koha/svc/suggestion?render=standalone&q=[% querystring | uri %]">suggestions</a></div> > [% END %] > >- [% IF ( koha_spsuggest ) %] >- Did you mean: >- <ul style="list-style: none;"> >- [% FOREACH SPELL_SUGGES IN SPELL_SUGGEST %] >- <li> >- <a href="/cgi-bin/koha/opac-search.pl?q=[% SPELL_SUGGES.spsuggestion | uri %]">[% SPELL_SUGGES.spsuggestion | html %]</a> >- </li> >- [% END %] >- </ul> >- [% END # / IF koha_spsuggest%] > [% IF ( total ) %] > [% IF ( ReturnPath ) %] > <div class="returntosearch"> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36224
:
162768
|
163014
|
163186