Bug 36224 - It looks like spsuggest functionality was removed years ago, but the templates still refer to it
Summary: It looks like spsuggest functionality was removed years ago, but the template...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 2539
Blocks:
  Show dependency tree / graph
 
Reported: 2024-03-04 16:25 UTC by Martin Renvoize (ashimema)
Modified: 2024-12-05 15:55 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10
Circulation function:

Attachments
Bug 36224: Remove unused spsuggest from templates (2.90 KB, patch)
2024-03-05 16:03 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 36224: Remove unused spsuggest from templates (2.95 KB, patch)
2024-03-10 02:12 UTC, David Nind 		Details | Diff | Splinter Review
Bug 36224: Remove unused spsuggest from templates (3.04 KB, patch)
2024-03-15 10:06 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-03-04 16:25:18 UTC 
opac-search.tt still refers to spsuggest but the git logs suggest the functionality was never fully implimented and the system preferences were removed long ago.. but they missed the template block.
Comment 1 Lucas Gass (lukeg) 2024-03-05 16:03:10 UTC 
Created attachment 162768 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!
Comment 2 David Nind 2024-03-10 02:12:28 UTC 
Created attachment 163014 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2024-03-15 10:06:36 UTC 
Created attachment 163186 [details] [review]
Bug 36224: Remove unused spsuggest from templates

To test:
-APPLY PATCH
-Review the OPAC results and staff interface results pages.
-Nothing should change, it would be impossible to end up inside of the [% IF koha_spsuggest %] condition because there is nothing like that in the scripts!

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-03-15 14:40:23 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-03-18 09:21:33 UTC 
Pushed to 23.11.x for 23.11.04
Comment 6 Lucas Gass (lukeg) 2024-03-19 21:47:21 UTC 
Backported to 23.05.x for upcoming 23.05.10