Bugzilla – Attachment 162945 Details for
Bug 33544
Squash some ILL fields to alleviate request table overflow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33544: Replace title details with one column
Bug-33544-Replace-title-details-with-one-column.patch (text/plain), 6.85 KB, created by
Martin Renvoize (ashimema)
on 2024-03-08 08:16:08 UTC
(
hide
)
Description:
Bug 33544: Replace title details with one column
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-03-08 08:16:08 UTC
Size:
6.85 KB
patch
obsolete
>From a6b5d68329409597fb67bc6a7d4bce6c0d31be76 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 5 May 2023 13:44:31 +0100 >Subject: [PATCH] Bug 33544: Replace title details with one column > >Combine the request title details fields into onea column for display. >--- > .../prog/en/includes/ill-list-table.inc | 12 +--- > .../intranet-tmpl/prog/js/ill-list-table.js | 69 +++++++------------ > 2 files changed, 27 insertions(+), 54 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >index 0ffe57d4dd6..1c5ec6e8b1d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc >@@ -9,14 +9,8 @@ > <tr id="ill_requests_header"> > <th scope="col">Request ID</th> > <th scope="col">Batch</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="author" data-related-search-on="value">Author</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="title" data-related-search-on="value">Title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="article_title" data-related-search-on="value">Article title</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="issue" data-related-search-on="value">Issue</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="volume" data-related-search-on="value">Volume</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="year" data-related-search-on="value">Year</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="pages" data-related-search-on="value">Pages</th> >- <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> >+ <th scope="col">Request details</th> >+ <th scope="col" data-datatype="related-object" data-related="extended_attributes" data-related-key="type" data-related-value="type" data-related-search-on="value">Request type</th> > <th scope="col">Order ID</th> > <th scope="col">Patron</th> > <th scope="col">Bibliographic record ID</th> >@@ -38,4 +32,4 @@ > </thead> > <tbody id="illview-body"> > </tbody> >-</table> >\ No newline at end of file >+</table> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 0a26a7209d6..89d5b9c72c3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -228,53 +228,32 @@ $(document).ready(function() { > : ""; > } > }, >- { >- "data": "", // author >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'author'); >- } >- }, >- { >- "data": "", // title >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'title'); >- } >- }, >- { >- "data": "", // article_title >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'article_title'); >- } >- }, >- { >- "data": "", // issue >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'issue'); >- } >- }, >- { >- "data": "", // volume >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'volume'); >- } >- }, >- { >- "data": "", // year >+ "data": "", // Request details > "orderable": false, > "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'year'); >- } >- }, >- { >- "data": "", // pages >- "orderable": false, >- "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'pages'); >+ let display = ''; >+ if ( display_extended_attribute(row, 'article_title') !== "" ) { >+ display += '<span style="display:block"> Article: ' + display_extended_attribute(row, 'article_title') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'title') !== "" ) { >+ display += '<span style="display:block"> Title: ' + display_extended_attribute(row, 'title') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'author') !== "" ) { >+ display += '<span style="display:block"> Author: ' + display_extended_attribute(row, 'author') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'issue') !== "" ) { >+ display += '<span style="display:block"> Issue: ' + display_extended_attribute(row, 'issue') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'volume') !== "" ) { >+ display += '<span style="display:block"> Volume: ' + display_extended_attribute(row, 'volume') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'year') !== "" ) { >+ display += '<span style="display:block"> Year: ' + display_extended_attribute(row, 'year') + '</span>'; >+ } >+ if ( display_extended_attribute(row, 'pages') !== "" ) { >+ display += '<span style="display:block"> Pages: ' + display_extended_attribute(row, 'pages') + '</span>'; >+ } >+ return display; > } > }, > { >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33544
:
152860
|
152861
|
152862
|
152863
|
159528
|
159529
|
159530
| 162945 |
162946
|
162947