Bug 33544 - Squash some ILL fields to alleviate request table overflow
Summary: Squash some ILL fields to alleviate request table overflow
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact:
URL:
Keywords:
Depends on: 22440
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-17 14:55 UTC by Martin Renvoize
Modified: 2024-04-25 13:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33544: WIP Replace title details with one column (6.17 KB, patch)
2023-06-29 11:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: WIP Replace title details with one column (6.89 KB, patch)
2023-06-29 11:27 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Update columns_settings.yml (1.34 KB, patch)
2023-06-29 11:55 UTC, Pedro Amorim
Details | Diff | Splinter Review
New 'details' column (197.73 KB, image/png)
2023-06-29 11:56 UTC, Pedro Amorim
Details
Bug 33544: Replace title details with one column (6.85 KB, patch)
2023-12-04 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Update columns_settings.yml (1.34 KB, patch)
2023-12-04 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Link title in details to biblio (3.71 KB, patch)
2023-12-04 14:40 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Replace title details with one column (6.85 KB, patch)
2024-03-08 08:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Update columns_settings.yml (1.34 KB, patch)
2024-03-08 08:16 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33544: Link title in details to biblio (3.71 KB, patch)
2024-03-08 08:16 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-04-17 14:55:49 UTC
The ILL requests' table listing all ILL requests is prone to overflowing it's container and requiring horizontal scrolling.

This is against a number of accessibility guidelines, and just doesn't look very nice.

I believe we could merge a number of the current columns to display the same data vertically in one column.

I think the item details (author, title, article title, issue, volume, year, pages) could all be merged into a column that looks more like how we display search catalogue search results.  That would save us a lot of horizontal space to start with.
Comment 1 Katrin Fischer 2023-04-23 12:38:00 UTC
I'd like to see a POC for this one and also think this might be what's best here to resolve the space issue. But we need to make sure that the information is still clearly distinguishable for librarians working with ILLs.
Comment 2 Martin Renvoize 2023-04-24 10:11:10 UTC
We'll knock something up once we have bug 22440 pushed :)
Comment 3 Martin Renvoize 2023-06-29 11:16:49 UTC
Created attachment 152860 [details] [review]
Bug 33544: WIP Replace title details with one column

Work in progress to combine the request title details fields into one
column for display.

table_settings needs to be changed to account for the new and missing
fields.
Comment 4 Martin Renvoize 2023-06-29 11:27:46 UTC
Created attachment 152861 [details] [review]
Bug 33544: WIP Replace title details with one column

Work in progress to combine the request title details fields into one
column for display.

table_settings needs to be changed to account for the new and missing
fields.
Comment 5 Pedro Amorim 2023-06-29 11:55:34 UTC
Created attachment 152862 [details] [review]
Bug 33544: Update columns_settings.yml

Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Comment 6 Pedro Amorim 2023-06-29 11:56:46 UTC
Created attachment 152863 [details]
New 'details' column

Screenshot of new column. 
Horizontal scrollbar still there but much less prominent.
Comment 7 Pedro Amorim 2023-06-29 11:59:28 UTC
Current WIP is breaking the small search input box on top of the table.
Comment 8 Lisette Scheer 2023-11-29 19:27:01 UTC
Bug 22384 suggests making the title clickable, which could be the "details' column and reduce one more column in width.
Comment 9 Martin Renvoize 2023-12-04 14:30:29 UTC
Hmm.. 

The biblio column is now a clickable representation of the biblio already.. it uses $biblio_to_html behind the scenes.

The other details that this patch merges into one field are those that were entered by the user when making the request..  We don't always have a linked biblio.

Needs a little thought
Comment 10 Martin Renvoize 2023-12-04 14:40:47 UTC
Created attachment 159528 [details] [review]
Bug 33544: Replace title details with one column

Combine the request title details fields into onea column for display.
Comment 11 Martin Renvoize 2023-12-04 14:40:50 UTC
Created attachment 159529 [details] [review]
Bug 33544: Update columns_settings.yml

Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Comment 12 Martin Renvoize 2023-12-04 14:40:52 UTC
Created attachment 159530 [details] [review]
Bug 33544: Link title in details to biblio

This patch removes the biblio id column and instead adds the biblio link
to the title field in the request details column when appropriate.
Comment 13 Lisette Scheer 2024-03-07 23:21:10 UTC
The table doesn't load and there's this error in the console:
SyntaxError: Unexpected token ':' (at ill-list-table_23.1200006.js:231:23)
Comment 14 Martin Renvoize 2024-03-08 08:16:08 UTC
Created attachment 162945 [details] [review]
Bug 33544: Replace title details with one column

Combine the request title details fields into onea column for display.
Comment 15 Martin Renvoize 2024-03-08 08:16:10 UTC
Created attachment 162946 [details] [review]
Bug 33544: Update columns_settings.yml

Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Comment 16 Martin Renvoize 2024-03-08 08:16:13 UTC
Created attachment 162947 [details] [review]
Bug 33544: Link title in details to biblio

This patch removes the biblio id column and instead adds the biblio link
to the title field in the request details column when appropriate.
Comment 17 Martin Renvoize 2024-03-08 08:17:05 UTC
Just a quick rebase here now that master has moved again.. I couldn't replicate your bug I'm afraid though Lisette. I'll try to swing back around and dig a little deeper when I get a moment.