The ILL requests' table listing all ILL requests is prone to overflowing it's container and requiring horizontal scrolling. This is against a number of accessibility guidelines, and just doesn't look very nice. I believe we could merge a number of the current columns to display the same data vertically in one column. I think the item details (author, title, article title, issue, volume, year, pages) could all be merged into a column that looks more like how we display search catalogue search results. That would save us a lot of horizontal space to start with.
I'd like to see a POC for this one and also think this might be what's best here to resolve the space issue. But we need to make sure that the information is still clearly distinguishable for librarians working with ILLs.
We'll knock something up once we have bug 22440 pushed :)
Created attachment 152860 [details] [review] Bug 33544: WIP Replace title details with one column Work in progress to combine the request title details fields into one column for display. table_settings needs to be changed to account for the new and missing fields.
Created attachment 152861 [details] [review] Bug 33544: WIP Replace title details with one column Work in progress to combine the request title details fields into one column for display. table_settings needs to be changed to account for the new and missing fields.
Created attachment 152862 [details] [review] Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Created attachment 152863 [details] New 'details' column Screenshot of new column. Horizontal scrollbar still there but much less prominent.
Current WIP is breaking the small search input box on top of the table.
Bug 22384 suggests making the title clickable, which could be the "details' column and reduce one more column in width.
Hmm.. The biblio column is now a clickable representation of the biblio already.. it uses $biblio_to_html behind the scenes. The other details that this patch merges into one field are those that were entered by the user when making the request.. We don't always have a linked biblio. Needs a little thought
Created attachment 159528 [details] [review] Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display.
Created attachment 159529 [details] [review] Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Created attachment 159530 [details] [review] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate.
The table doesn't load and there's this error in the console: SyntaxError: Unexpected token ':' (at ill-list-table_23.1200006.js:231:23)
Created attachment 162945 [details] [review] Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display.
Created attachment 162946 [details] [review] Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Created attachment 162947 [details] [review] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate.
Just a quick rebase here now that master has moved again.. I couldn't replicate your bug I'm afraid though Lisette. I'll try to swing back around and dig a little deeper when I get a moment.
I had a go at testing, however I think with some of the changes in train for ILL that this may need some more work? I tested with the ILL FreeForm backend, with the 24.05.x branch. However, after the patch the list of ILL requests does not actually list the requests - you get the table headings, but no details and a JavScript error (when using the developer tools): Uncaught SyntaxError: Unexpected token ':' (at ill-list-table_24.0600000.js:246:23) No metadata enrichment plugins found. ill-batch-modal_24.0600000.js:4 Draft test plan: 1. Enable the ILL module and an ILL backend: . bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) . change to the FreeForm directory: cd Koha/Illbackends/FreeForm . checkout the 24.05.x branch: git checkout 24.05.x 2. Create an ILL request (any type is fine, Journal article recommended) 3. List all ILL requests - note that table goes off the page to the right). 4. Apply the patch and restart everything. 5. Duplicate the tab (so that you can compare the table layout) and refresh the page. 6. Notice that: . the title details (columns for author, title, article title, issue, volume, year, pages) are now in one column, Request details . there is a Batch column (?) . to edit the request, click on XXX . the table no longer overflows 7. Sign off D:
The patch no longer applies 8-(... git bz apply 33544 Bug 33544 - Squash some ILL fields to alleviate request table overflow 162945 - Bug 33544: Replace title details with one column 162946 - Bug 33544: Update columns_settings.yml 162947 - Bug 33544: Link title in details to biblio Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 33544: Replace title details with one column Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js error: Failed to merge in the changes. Patch failed at 0001 Bug 33544: Replace title details with one column
This table is not nice at all, especially with an action button in the last column, which is displayed off-screen
I would like to test this patch. Could you rebase it please?
From your capture, even with your patch the action button on the last column will be out of screen :/ Is there places in Koha where action button within tables are on the 1st column rather than the last one?
I am not sure the biblionumber should have its own colum. Why not using it to make a link to the title record in the 1st column ?
I tried running the auto-rebase script on this (after applying it to 285a0fc74da5747922bcc28626066a7067e4fb66) but it did not like it!
It seems to be Koha convention to put the action button in the right-most column (e.g. for Reports) but the opposite, putting it on the left, is more usable. I frequently have trouble with horizontal-scrolling (which is more difficult than vertical scrolling in most web browsers) when tables contain many columns. Just an opinion, I do not know if this is a formalized convention that would violate a style guide or merely how things tend to have been done. Which is all to say I very much appreciate this patch.
I don't care if it is on the right or the left but on UX point of view it is not good to have to scroll to access the button. There are at least 1 place in Koha where action buttons are on the left : the edit item table (koha/cataloguing/additem.pl?op=edititem). But maybe not a good idea to follow this example. Anyway moving the button is not the goal of this patch...
Created attachment 179227 [details] [review] Bug 33544: Replace title details with one column Combine the request title details fields into onea column for display.
Created attachment 179228 [details] [review] Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least.
Created attachment 179229 [details] [review] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate.
Applies again now.. only twenty-three months gone by.
Created attachment 179232 [details] [review] Bug 33544: Link title in details to biblio This patch removes the biblio id column and instead adds the biblio link to the title field in the request details column when appropriate. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Created attachment 179233 [details] [review] Bug 33544: Update columns_settings.yml Wonder if year should be out of the details? In case we want to sort by year, its not sortable anyway at the moment but we need to keep in mind that fields bundled here will not be sortable. It does not seem to cause any issues on searching at first glance, at least. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Created attachment 179234 [details] [review] Bug 33544: Replace title details with one column Combine the request title details fields into one column for display. Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
While I agree that having buttons on the left makes sense for usability, that's a larger convention change than the scope of this bug.