Attachment 163053 Details for Bug 15565 – Bug 15565: Tidy reserve/placerequest.pl

[patch] Bug 15565: Tidy reserve/placerequest.pl

Bug-15565-Tidy-reserveplacerequestpl.patch (text/plain), 3.20 KB, created by Nick Clemens (kidclamp) on 2024-03-11 19:06:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-03-11 19:06:16 UTC

Size: 3.20 KB

patch

obsolete

>From 6804947a55796a8be159a6ae6ee8de8964375612 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 12 Feb 2024 23:20:35 +0000
>Subject: [PATCH] Bug 15565: Tidy reserve/placerequest.pl
>
>---
> reserve/placerequest.pl | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
>diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
>index 48dd0636c58..44dd3f24dd3 100755
>--- a/reserve/placerequest.pl
>+++ b/reserve/placerequest.pl
>@@ -44,7 +44,7 @@ my $branch         = $input->param('pickup');
> my $startdate      = $input->param('reserve_date') || '';
> my @rank           = $input->multi_param('rank-request');
> my $title          = $input->param('title');
>-my @checkitems      = $input->multi_param('checkitem');
>+my @checkitems = $input->multi_param('checkitem');
> my $item_group_id  = $input->param('item_group_id');
> my $expirationdate = $input->param('expiration_date');
> my $itemtype       = $input->param('itemtype') || undef;
>@@ -72,7 +72,7 @@ if ( $op eq 'cud-placerequest' && $patron ) {
> 
>         my $can_override = C4::Context->preference('AllowHoldPolicyOverride');
>         if ( @checkitems ) {
>-            for ( my $i = 0; $i < scalar @checkitems; $i++ ){
>+            for ( my $i = 0 ; $i < scalar @checkitems ; $i++ ) {
>                 my $checkitem = $checkitems[$i];
>                 if ( my $item_pickup_location = $input->param("item_pickup_$checkitem") ) {
> 
>@@ -82,9 +82,11 @@ if ( $op eq 'cud-placerequest' && $patron ) {
>                         $biblionumber = $item->biblionumber;
>                     }
> 
>-                    my $can_item_be_reserved = CanItemBeReserved($patron, $item, $item_pickup_location)->{status};
>+                    my $can_item_be_reserved = CanItemBeReserved( $patron, $item, $item_pickup_location )->{status};
> 
>-                    if ( $can_item_be_reserved eq 'OK' || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) ) {
>+                    if ( $can_item_be_reserved eq 'OK'
>+                        || ( $can_item_be_reserved ne 'itemAlreadyOnHold' && $can_override ) )
>+                    {
>                         AddReserve(
>                             {
>                                 branchcode       => $item_pickup_location,
>@@ -102,8 +104,7 @@ if ( $op eq 'cud-placerequest' && $patron ) {
>                             }
>                         );
> 
>-                    }
>-                    else {
>+                    } else {
>                         $failed_holds{$can_item_be_reserved} = 1;
>                     }
>                 }
>@@ -157,11 +158,12 @@ if ( $op eq 'cud-placerequest' && $patron ) {
> 
>     my $redirect_url = URI->new("request.pl");
>     my @failed_hold_msgs = ();
>+
>     #NOTE: Deduplicate failed hold reason statuses/codes
>-    foreach my $msg (keys %failed_holds){
>-        push(@failed_hold_msgs,$msg);
>+    foreach my $msg ( keys %failed_holds ) {
>+        push( @failed_hold_msgs, $msg );
>     }
>-    $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs);
>+    $redirect_url->query_form( biblionumber => [@biblionumbers], failed_holds => \@failed_hold_msgs );
>     print $input->redirect($redirect_url);
> }
> elsif ( $borrowernumber eq '' ) {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 15565: 47527 | 47551 | 47552 | 50068 | 50069 | 50392 | 50393 | 56229 | 56230 | 56231 | 56232 | 56458 | 56510 | 56511 | 56512 | 56513 | 56514 | 56515 | 56517 | 56518 | 56519 | 56520 | 56521 | 56522 | 56523 | 56524 | 61244 | 61245 | 61246 | 61247 | 61248 | 61576 | 61577 | 61578 | 61579 | 61580 | 64590 | 64591 | 64592 | 64593 | 64594 | 66594 | 66595 | 66596 | 66597 | 66598 | 68759 | 68760 | 68761 | 68762 | 68763 | 71643 | 71644 | 71645 | 71646 | 71647 | 71648 | 72644 | 72645 | 72646 | 72647 | 72648 | 72649 | 78242 | 78243 | 78244 | 78245 | 78246 | 78247 | 78248 | 78266 | 78305 | 78417 | 78418 | 78419 | 78420 | 78421 | 78422 | 78423 | 78424 | 78425 | 78426 | 78712 | 78713 | 78714 | 78715 | 78716 | 78717 | 78718 | 78719 | 78720 | 78815 | 78816 | 78817 | 78818 | 78819 | 78820 | 78821 | 78822 | 78823 | 81419 | 81420 | 81421 | 81422 | 81423 | 81424 | 81425 | 81426 | 81427 | 81431 | 81449 | 81570 | 81571 | 81572 | 81573 | 81574 | 81575 | 81576 | 81577 | 81578 | 81579 | 81580 | 81581 | 82205 | 82206 | 82207 | 82208 | 82209 | 82210 | 82211 | 82212 | 82213 | 82214 | 82215 | 82216 | 82220 | 82221 | 83331 | 83332 | 83333 | 83334 | 83335 | 83336 | 83337 | 83338 | 83339 | 83340 | 83341 | 83342 | 83378 | 83380 | 83381 | 84541 | 84542 | 84543 | 84544 | 84545 | 84546 | 84547 | 84548 | 84549 | 84550 | 84551 | 84552 | 84553 | 87979 | 87980 | 87981 | 87982 | 87983 | 87984 | 87985 | 87986 | 87987 | 87988 | 87989 | 87990 | 87991 | 117128 | 117129 | 117130 | 117131 | 117132 | 117133 | 120365 | 120366 | 120367 | 120639 | 120640 | 120641 | 121941 | 122098 | 162071 | 162072 | 162073 | 162074 | 163052 | 163053 | 163054 | 163055 | 163092 | 163093 | 166005 | 166006 | 166007 | 166008 | 166009